8301788: AlgorithmId should keep lowercase characters from 3rd party providers

[wangweij]

Keep the "NAME -> 1.2.3.4" mapping unchanged but modify "1.2.3.4 -> NAME" to "1.2.3.4 -> Name".

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301788: AlgorithmId should keep lowercase characters from 3rd party providers

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12410/head:pull/12410
$ git checkout pull/12410

Update a local copy of the PR:
$ git checkout pull/12410
$ git pull https://git.openjdk.org/jdk pull/12410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12410

View PR using the GUI difftool:
$ git pr show -t 12410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12410.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (42fb5d4a)
• 01: Full - Incremental (61f3448c)
• 00: Full (26581839)

[seanjmullan]

Do you need this module?

[wangweij]

AlgorithmId.get(ALG).getOID().toString() calls sun.security.util.ObjectIdentifier::toString.

Uppercase.java:46: error: ObjectIdentifier.toString() in package sun.security.util is not accessible
        Asserts.assertEQ(AlgorithmId.get(ALG).getOID().toString(), OID);
                                                      ^
  (package sun.security.util is declared in module java.base, which does not export it to the unnamed module)

[seanjmullan]

ok

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301788: AlgorithmId should keep lowercase characters from 3rd party providers

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

• 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
• ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
• 7ae447f: 8301095: [s390x] TestDwarf.java fails
• 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
• 8e9b726: 8301599: Serial: Refactor nested closures in DefNewGeneration
• 7730506: 8299162: Refactor shared trampoline emission logic
• 522fa13: 8301580: Error recovery does not clear returnResult
• 7ac2079: 8301025: ClassCastException in switch with generic record
• 371a0c4: 8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel
• 716f1df: 8301478: Replace NULL with nullptr in os/bsd
• ... and 56 more: https://git.openjdk.org/jdk/compare/8d6e8a47c94ad72d380b72b421d9a27d59e6ce33...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

/integrate

[openjdk]

Going to push as commit b569742.
Since your change was applied there have been 66 commits pushed to the master branch:

• 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
• ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
• 7ae447f: 8301095: [s390x] TestDwarf.java fails
• 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
• 8e9b726: 8301599: Serial: Refactor nested closures in DefNewGeneration
• 7730506: 8299162: Refactor shared trampoline emission logic
• 522fa13: 8301580: Error recovery does not clear returnResult
• 7ac2079: 8301025: ClassCastException in switch with generic record
• 371a0c4: 8301465: Remove unnecessary nmethod arming in Full GC of Serial/Parallel
• 716f1df: 8301478: Replace NULL with nullptr in os/bsd
• ... and 56 more: https://git.openjdk.org/jdk/compare/8d6e8a47c94ad72d380b72b421d9a27d59e6ce33...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit b569742.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.