8300177 : URISyntaxException fields can be final

[DarraghClarke]

Made the two fields input and index final, this didn't need any test changes as far as I could tell so this PR is longer than the diff

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300177: URISyntaxException fields can be final

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12415/head:pull/12415
$ git checkout pull/12415

Update a local copy of the PR:
$ git checkout pull/12415
$ git pull https://git.openjdk.org/jdk pull/12415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12415

View PR using the GUI difftool:
$ git pr show -t 12415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12415.diff

[bridgekeeper]

👋 Welcome back DarraghClarke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DarraghClarke The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (75bd4bc6)

[openjdk]

@DarraghClarke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300177: URISyntaxException fields can be final

Reviewed-by: dfuchs, alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 232 new commits pushed to the master branch:

• c61a382: 8296646: com/sun/jdi/JdbLastErrorTest.java test failure
• f5f38a8: 8301371: Interpreter store barriers on x86_64 don't have disjoint temp registers
• 77dbcd8: 8301641: NativeMemoryUsageTotal event uses reserved value for committed field
• 1aaf394: 8301736: jdk/incubator/concurrent/StructuredTaskScope/StructuredTaskScopeTest.java fail with -Xcomp
• 9dad874: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
• 98433a2: 8296999: AArch64: scalar intrinsics for reverse method in Integer and Long
• c04a982: 8301818: RISC-V: Factor out function mvw from MacroAssembler
• 787e16b: 8289077: Add manual tests to open
• 07fb4f9: 7167356: (javac) investigate failing tests in JavacParserTest
• 3ac2bed: 8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah
• ... and 222 more: https://git.openjdk.org/jdk/compare/048705c04967d106dedc09a4cf2325a3b46ef4e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @AlanBateman, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jaikiran]

This looks fine to me.

Adding a final to a field of a Serializable type can change the auto-generated value of serialVersionUID. In this case (like all other Serializable types in the JDK), the class explicitly specifies a serialVersionUID value, so this change won't impact that value.

[DarraghClarke]

/integrate

[openjdk]

@DarraghClarke
Your change (at version 75bd4bc) is now ready to be sponsored by a Committer.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit 09b8a19.
Since your change was applied there have been 232 commits pushed to the master branch:

• c61a382: 8296646: com/sun/jdi/JdbLastErrorTest.java test failure
• f5f38a8: 8301371: Interpreter store barriers on x86_64 don't have disjoint temp registers
• 77dbcd8: 8301641: NativeMemoryUsageTotal event uses reserved value for committed field
• 1aaf394: 8301736: jdk/incubator/concurrent/StructuredTaskScope/StructuredTaskScopeTest.java fail with -Xcomp
• 9dad874: 8298413: [s390] CPUInfoTest fails due to uppercase feature string
• 98433a2: 8296999: AArch64: scalar intrinsics for reverse method in Integer and Long
• c04a982: 8301818: RISC-V: Factor out function mvw from MacroAssembler
• 787e16b: 8289077: Add manual tests to open
• 07fb4f9: 7167356: (javac) investigate failing tests in JavacParserTest
• 3ac2bed: 8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah
• ... and 222 more: https://git.openjdk.org/jdk/compare/048705c04967d106dedc09a4cf2325a3b46ef4e7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @DarraghClarke Pushed as commit 09b8a19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.