8301798: [BACKOUT] jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL

[plummercj]

Backing out the following due to numerous failing tests. There will be no redo. The original change was an enhancement, not a bug fix.

JDK-8300811 jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL

Tested with 100 runs of com/sun/jdi on macosx-x64 (product build) which is where almost all of the failures were reported. Also did a full tier3 mach5 run.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301798: [BACKOUT] jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12416/head:pull/12416
$ git checkout pull/12416

Update a local copy of the PR:
$ git checkout pull/12416
$ git pull https://git.openjdk.org/jdk pull/12416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12416

View PR using the GUI difftool:
$ git pr show -t 12416

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12416.diff

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[plummercj]

/issue JDK-8301695

[openjdk]

@plummercj
Adding additional issue to issue list: 8301695: com/sun/jdi/JdbOptions.java failed with "RuntimeException: waitForPrompt timed out after 240 seconds".

[plummercj]

/issue JDK-8301735

[plummercj]

/issue JDK-8301795

[openjdk]

@plummercj
Adding additional issue to issue list: 8301735: Test com/sun/jdi/RedefineG.java timing out on macos.

[openjdk]

@plummercj
Adding additional issue to issue list: 8301795: com/sun/jdi/RedefineIntConstantToLong.java failed with "waitForPrompt timed out".

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (20f34c6a)

[dcubed-ojdk]

This looks like a clean [BACKOUT] to me. So thumbs up and it looks trivial.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301798: [BACKOUT] jdb ThreadStartRequest and ThreadDeathRequest should use SUSPEND_NONE instead of SUSPEND_ALL

Reviewed-by: dcubed, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• e7247b1: 8298872: Update CheckStatus.java for changes to TLS implementation
• 20579e4: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Looks good. Thanks

[dholmes-ora]

@plummercj I don't think this PR should list all the test failure issues. While it is true that the backout will "fix" those failures, I don't think that is the intended use of the mechanism. What do you think @dcubed-ojdk ?

[plummercj]

Should I close those issues as dups of the backup issue?

[dcubed-ojdk]

I would be fine with either mechanism. I think closing the test failure bugs as
dups is the more typical usage model.

[plummercj]

/issue remove JDK-8301695,JDK-8301735,JDK-8301795

[openjdk]

@plummercj
Removing additional issue from issue list: 8301695.

Removing additional issue from issue list: 8301735.

Removing additional issue from issue list: 8301795.

[plummercj]

Thanks for the reviews David and Dan!

/integrate

[openjdk]

Going to push as commit 3be5317.
Since your change was applied there have been 2 commits pushed to the master branch:

• e7247b1: 8298872: Update CheckStatus.java for changes to TLS implementation
• 20579e4: 8299994: java/security/Policy/Root/Root.java fails when home directory is read-only

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 3be5317.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.