8301818: RISC-V: Factor out function mvw from MacroAssembler #12425

zifeihan · 2023-02-04T06:42:33Z

HI,

The two functions of mvw and mv overlap, we can use mv to replace mvw, so the mvw function can be removed. and format some code.

Testing:

all tier1 on unmatched board without new failures

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8301818: RISC-V: Factor out function mvw from MacroAssembler

Reviewers

Ludovic Henry (@luhenry - Committer)
Fei Yang (@RealFYang - Reviewer)
Feilong Jiang (@feilongjiang - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12425/head:pull/12425
$ git checkout pull/12425

Update a local copy of the PR:
$ git checkout pull/12425
$ git pull https://git.openjdk.org/jdk pull/12425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12425

View PR using the GUI difftool:
$ git pr show -t 12425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12425.diff

bridgekeeper · 2023-02-04T06:44:01Z

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-02-04T06:46:06Z

@zifeihan The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-02-04T06:51:35Z

Webrevs

01: Full - Incremental (a4a05c55)
00: Full (e468629e)

luhenry · 2023-02-04T10:52:50Z

src/hotspot/cpu/riscv/vtableStubs_riscv.cpp

@@ -89,8 +89,8 @@ VtableStub* VtableStubs::create_vtable_stub(int vtable_index) {
    start_pc = __ pc();

    // check offset vs vtable length
-    __ lwu(t0, Address(t2, Klass::vtable_length_offset()));


There is an extra lwu -> lw which doesn't happen anywhere else.

Thanks for your review. fixed.

openjdk · 2023-02-06T02:24:58Z

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301818: RISC-V: Factor out function mvw from MacroAssembler

Reviewed-by: luhenry, fyang, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

787e16b: 8289077: Add manual tests to open
07fb4f9: 7167356: (javac) investigate failing tests in JavacParserTest
3ac2bed: 8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah
d53ade1: 8301813: Bad caret position in error message
8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
7ae447f: 8301095: [s390x] TestDwarf.java fails
... and 24 more: https://git.openjdk.org/jdk/compare/7435b27d6808cf2f669033440ccf6638640e2a32...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@luhenry, @RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

zifeihan · 2023-02-07T04:37:39Z

Thanks all for the review.
/integrate

openjdk · 2023-02-07T04:39:01Z

@zifeihan
Your change (at version a4a05c5) is now ready to be sponsored by a Committer.

RealFYang · 2023-02-07T04:48:18Z

/sponsor

openjdk · 2023-02-07T04:49:08Z

Going to push as commit c04a982.
Since your change was applied there have been 34 commits pushed to the master branch:

787e16b: 8289077: Add manual tests to open
07fb4f9: 7167356: (javac) investigate failing tests in JavacParserTest
3ac2bed: 8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah
d53ade1: 8301813: Bad caret position in error message
8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
7ae447f: 8301095: [s390x] TestDwarf.java fails
... and 24 more: https://git.openjdk.org/jdk/compare/7435b27d6808cf2f669033440ccf6638640e2a32...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-02-07T04:49:26Z

@RealFYang @zifeihan Pushed as commit c04a982.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Small Optimizing for use mv to replace mvw

e468629

zifeihan changed the title ~~Small Optimizing for use mv to replace mvw~~ 8301818: RISC-V: Small Optimizing for use mv to replace mvw Feb 4, 2023

openjdk bot added hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review labels Feb 4, 2023

zifeihan changed the title ~~8301818: RISC-V: Small Optimizing for use mv to replace mvw~~ 8301818: RISC-V: Factor out function mvw from MacroAssembler Feb 4, 2023

luhenry reviewed Feb 4, 2023

View reviewed changes

Revert use lwu

a4a05c5

luhenry approved these changes Feb 4, 2023

View reviewed changes

RealFYang approved these changes Feb 6, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Feb 6, 2023

feilongjiang approved these changes Feb 7, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 7, 2023

openjdk bot added the integrated Pull request has been integrated label Feb 7, 2023

openjdk bot closed this Feb 7, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 7, 2023

zifeihan deleted the JDK-8301818 branch February 7, 2023 10:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8301818: RISC-V: Factor out function mvw from MacroAssembler #12425

8301818: RISC-V: Factor out function mvw from MacroAssembler #12425

Uh oh!

zifeihan commented Feb 4, 2023 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Feb 4, 2023

Uh oh!

openjdk bot commented Feb 4, 2023

Uh oh!

mlbridge bot commented Feb 4, 2023 •

edited

Loading

Uh oh!

luhenry Feb 4, 2023

Uh oh!

zifeihan Feb 4, 2023

Uh oh!

openjdk bot commented Feb 6, 2023 •

edited

Loading

Uh oh!

zifeihan commented Feb 7, 2023

Uh oh!

openjdk bot commented Feb 7, 2023

Uh oh!

RealFYang commented Feb 7, 2023

Uh oh!

openjdk bot commented Feb 7, 2023

Uh oh!

openjdk bot commented Feb 7, 2023

Uh oh!

Uh oh!

8301818: RISC-V: Factor out function mvw from MacroAssembler #12425

8301818: RISC-V: Factor out function mvw from MacroAssembler #12425

Uh oh!

Conversation

zifeihan commented Feb 4, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing:

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Feb 4, 2023

Uh oh!

openjdk bot commented Feb 4, 2023

Uh oh!

mlbridge bot commented Feb 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

luhenry Feb 4, 2023

Choose a reason for hiding this comment

Uh oh!

zifeihan Feb 4, 2023

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Feb 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zifeihan commented Feb 7, 2023

Uh oh!

openjdk bot commented Feb 7, 2023

Uh oh!

RealFYang commented Feb 7, 2023

Uh oh!

openjdk bot commented Feb 7, 2023

Uh oh!

openjdk bot commented Feb 7, 2023

Uh oh!

Uh oh!

zifeihan commented Feb 4, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 4, 2023 •

edited

Loading

openjdk bot commented Feb 6, 2023 •

edited

Loading