8301853: C4819 warnings were reported in HotSpot on Windows

[YaSuenag]

This is subtask of #12427 .

I have seen C4819 warning in stubGenerator_x86_64_poly.cpp and elfFile.hpp in HotSpot on Windows (CP932: Japanese locale)

d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): error C2220: 次の警告はエラーとして処理されます
d:\github-forked\jdk\src\hotspot\cpu\x86\stubGenerator_x86_64_poly.cpp(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301853: C4819 warnings were reported in HotSpot on Windows

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12435/head:pull/12435
$ git checkout pull/12435

Update a local copy of the PR:
$ git checkout pull/12435
$ git pull https://git.openjdk.org/jdk pull/12435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12435

View PR using the GUI difftool:
$ git pr show -t 12435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12435.diff

[bridgekeeper]

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@YaSuenag The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5f2e38b6)

[dholmes-ora]

Looks good and trivial. Thanks for fixing.

[openjdk]

@YaSuenag This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301853: C4819 warnings were reported in HotSpot on Windows

Reviewed-by: dholmes, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• c92a7de: 8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java
• 0f08785: 8301756: Missed constructor from 8301659
• 4de2d3c: 8301862: G1: Remove G1PageBasedVirtualSpace::_executable
• e628fd5: 8301214: Adjust handshakeTimeout value in test HandshakeTimeout.java after 8189338
• ac7119f: 8280126: C2: detect and remove dead irreducible loops
• 2a579ab: 8292588: [macos] Multiscreen/MultiScreenLocationTest/MultiScreenLocationTest.java: Robot.mouseMove test failed on Screen #0
• 53f72ed: 8286510: Tests under dynamicArchive/methodHandles should check for loading of lambda proxy classes
• 74485a3: 8301810: Bug in doctree DocCommentTester.compress
• 2712615: 8298445: Add LeakSanitizer support in HotSpot
• 2e2e71e: 8300416: java.security.MessageDigestSpi clone can result in thread-unsafe clones
• ... and 24 more: https://git.openjdk.org/jdk/compare/7ac2079ba7dd07c61576e0b39692a94eecc96e07...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

I note from the related PRs that they are not being fixed due to "building with the 'wrong' locale", but I would still want to see this change integrated for hotspot because the problematic characters in src/hotspot/cpu/x86/stubGenerator_x86_64_poly.cpp do not display correctly in text editors (the multiplication sign displays for me as a capital A with a tilde over it).

[YaSuenag]

We continue to discuss for the encoding of source files in #12436, but I want to merge this to master branch because this PR changes comments only.

[magicus]

Please hold on and do not merge this PR.

The problem here is that the encoding of the file is not properly conveyed. This is code written by Intel where the original author clearly put in the time to use a separate mathematical sign to clarify the discussion. I think this should not just be trivially removed. Let's fix this properly instead.

[mlbridge]

Mailing list message from Maxim Degtyarev on hotspot-dev:

Isn't it better to replace the multiplication sign with an asterisk
(*) instead of the letter 'x'?
The 'a2xr0 ' looks like a cryptic identifier and not the "multiply a2
to r0". Same for all other changes.

El mar, 7 feb 2023 a las 5:51, Yasumasa Suenaga
(<ysuenaga at openjdk.org>) escribi?:

[dholmes-ora]

Isn't it better to replace the multiplication sign with an asterisk (*) instead of the letter 'x'?

No. Asterisk is already used to mean something else

//    * used for poly1305_multiply_scalar
//    x used for poly1305_multiply8_avx512

The problem here is that the encoding of the file is not properly conveyed.

@magicus That may be the problem with the warning, but I'm more concerned that the special characters won't display properly in some editing environments. So as a change to hotspot code I am happy to see this go in.

[dholmes-ora]

Visually the difference between × and x is minimal. Whereas seeing à in place of x is very disruptive. Sure you could argue this is an environment issue and the multiplication symbol should display properly with the right settings, but it is trivial fix, with zero harm, to just replace it with plain x.

[magicus]

Ok, it's your code, so if you want an x instead, go ahead. I fully agree that some special non-ASCII character has no need in the source code, like typographic quotes, and should be replaced by normal ASCII character. I would not have counted this multiplication symbol as unnecessary, but I understand and respect that you think otherwise.

[YaSuenag]

/integrate

[openjdk]

Going to push as commit c72f951.
Since your change was applied there have been 48 commits pushed to the master branch:

• 36478ee: 8288783: Error messages are confusing when options conflict in -XX:StartFlightRecording
• 70f3150: 8301443: Clean broken comments from Windows code
• 5561c39: 8294484: MetalBorder's FrameBorder & DialogBorder have border rendering issues when scaled
• c8cc7b6: 8301704: Shorten the number of GCs in UnloadingTest.java to verify a class loader not being unloaded
• dc6d52c: 8301876: Crash in DumpTimeClassInfo::add_verification_constraint
• 873558e: 8300914: Allow @ as an escape in documentation comments
• 8a9e383: 8301717: Remove obsolete jib profiles
• 631a279: 8301567: The test/jdk/java/awt/AppContext/ApplicationThreadsStop/java.policy is unused
• 638d612: 8298478: (fs) Path.of should allow input to include long path prefix
• 10dd98d: 8301462: Convert Permission files to use lambda after JDK-8076596
• ... and 38 more: https://git.openjdk.org/jdk/compare/7ac2079ba7dd07c61576e0b39692a94eecc96e07...master

Your commit was automatically rebased without conflicts.

[openjdk]

@YaSuenag Pushed as commit c72f951.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.