Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301855: C4819 warnings were reported in harfbuzz on Windows #12437

Closed
wants to merge 1 commit into from

Conversation

YaSuenag
Copy link
Member

@YaSuenag YaSuenag commented Feb 6, 2023

This is subtask of #12427 .

I have seen C4819 warning in harfbuzz files on Windows (CP932: Japanese locale)

d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1): error C2220: 次の警告はエラーとして処理されます
d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1): warning C4819: ファイルは、現在のコード ページ (932) で表示できない文字を含んでいます。データの損失を防ぐために、ファイルを Unicode 形式で保存してください。

I added C4819 to DISABLED_WARNINGS_microsoft for libfontmanager and for libfreetype because they are 3rd-party libraries.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301855: C4819 warnings were reported in harfbuzz on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12437/head:pull/12437
$ git checkout pull/12437

Update a local copy of the PR:
$ git checkout pull/12437
$ git pull https://git.openjdk.org/jdk pull/12437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12437

View PR using the GUI difftool:
$ git pr show -t 12437

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12437.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2023

👋 Welcome back ysuenaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@YaSuenag The following labels will be automatically applied to this pull request:

  • build
  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org client client-libs-dev@openjdk.org labels Feb 6, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 6, 2023

Webrevs

@prrace
Copy link
Contributor

prrace commented Feb 6, 2023

I notice you didn't bother telling folks what this warning is
It is
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4819?view=msvc-170
"The file contains a character that cannot be represented in the current code page (number)."

JDK does not support being built in arbitrary locales.
And the warning comes from hb.hh at some line you don't reveal so I can't tell if its in a comment or something more critical, and then since its in a central header file I can't tell if its the only such warning or not.

This fix is rejected. Build in an English locale.

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not integrate this. See the other sub-tasks for discussion.

@YaSuenag
Copy link
Member Author

YaSuenag commented Feb 9, 2023

This issue will be treated in JDK-8301971

@YaSuenag YaSuenag closed this Feb 9, 2023
@YaSuenag YaSuenag deleted the JDK-8301855 branch February 9, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants