8301855: C4819 warnings were reported in harfbuzz on Windows #12437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subtask of #12427 .
I have seen C4819 warning in harfbuzz files on Windows (CP932: Japanese locale)
I added C4819 to DISABLED_WARNINGS_microsoft for libfontmanager and for libfreetype because they are 3rd-party libraries.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12437/head:pull/12437
$ git checkout pull/12437
Update a local copy of the PR:
$ git checkout pull/12437
$ git pull https://git.openjdk.org/jdk pull/12437/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12437
View PR using the GUI difftool:
$ git pr show -t 12437
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12437.diff