7167356: (javac) investigate failing tests in JavacParserTest

[archiecobbs]

This bug, created back in 2012, notes that three of the unit @Tests in parser/JavacParserTest.java are disabled because the functionality they verify was not yet implemented correctly at that time.

That was a long time ago, and since then the functionality has been fixed and the tests are now working properly, so they can be enabled at long last.

The third test also needs to be adjusted in order to succeed. It was (for some reason) expecting that an enum constant's source position would be reported as offset -1, instead of its actual source position (in this case, 23).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-7167356: (javac) investigate failing tests in JavacParserTest

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12444/head:pull/12444
$ git checkout pull/12444

Update a local copy of the PR:
$ git checkout pull/12444
$ git pull https://git.openjdk.org/jdk pull/12444/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12444

View PR using the GUI difftool:
$ git pr show -t 12444

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12444.diff

[bridgekeeper]

👋 Welcome back archiecobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b72b9d9c)

[vicente-romero-oracle]

looks good, thanks for fixing this

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7167356: (javac) investigate failing tests in JavacParserTest

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

• d53ade1: 8301813: Bad caret position in error message
• 8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
• c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
• b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
• 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
• ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
• 7ae447f: 8301095: [s390x] TestDwarf.java fails
• 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
• 8e9b726: 8301599: Serial: Refactor nested closures in DefNewGeneration
• 7730506: 8299162: Refactor shared trampoline emission logic
• ... and 64 more: https://git.openjdk.org/jdk/compare/960c3931337b314417ad33d8a775ee3e251692d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[archiecobbs]

/integrate

[openjdk]

@archiecobbs
Your change (at version b72b9d9) is now ready to be sponsored by a Committer.

[vicente-romero-oracle]

/sponsor

[openjdk]

Going to push as commit 07fb4f9.
Since your change was applied there have been 75 commits pushed to the master branch:

• 3ac2bed: 8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah
• d53ade1: 8301813: Bad caret position in error message
• 8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
• c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
• b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
• 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
• ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
• 7ae447f: 8301095: [s390x] TestDwarf.java fails
• 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
• 8e9b726: 8301599: Serial: Refactor nested closures in DefNewGeneration
• ... and 65 more: https://git.openjdk.org/jdk/compare/960c3931337b314417ad33d8a775ee3e251692d7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle @archiecobbs Pushed as commit 07fb4f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.