Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8289077: Add manual tests to open #12447

Closed
wants to merge 2 commits into from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Feb 6, 2023

Following manual tests added -

  1. test/jdk/java/awt/Frame/ALTTABIconBeingErased/ALTTABIconBeingErased.java
  2. test/jdk/java/awt/Icon/IconChangingTest/IconChangingTest.java
  3. test/jdk/java/awt/Icon/IconShowingTest/IconShowingTest.java
  4. test/jdk/java/awt/Icon/IconTransparencyTest/IconTransparencyTest.java
  5. test/jdk/java/awt/Icon/SetLargeIconTest/SetLargeIconTest.java

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12447/head:pull/12447
$ git checkout pull/12447

Update a local copy of the PR:
$ git checkout pull/12447
$ git pull https://git.openjdk.org/jdk pull/12447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12447

View PR using the GUI difftool:
$ git pr show -t 12447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12447.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2023

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Feb 6, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 6, 2023

Webrevs

* @library /java/awt/regtesthelpers /test/lib
* @build PassFailJFrame jdk.test.lib.Platform
* @run main/manual IconChangingTest
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat: looks like a missing empty line in every test.

@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289077: Add manual tests to open

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 07fb4f9: 7167356: (javac) investigate failing tests in JavacParserTest
  • 3ac2bed: 8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah
  • d53ade1: 8301813: Bad caret position in error message
  • 8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
  • c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
  • b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
  • 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
  • ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
  • 7ae447f: 8301095: [s390x] TestDwarf.java fails
  • 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
  • ... and 15 more: https://git.openjdk.org/jdk/compare/d67bfe21a23fea2d9ef4eef4e811b774cca2ab94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 6, 2023
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2023

Going to push as commit 787e16b.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 07fb4f9: 7167356: (javac) investigate failing tests in JavacParserTest
  • 3ac2bed: 8299324: inline_native_setCurrentThread lacks GC barrier for Shenandoah
  • d53ade1: 8301813: Bad caret position in error message
  • 8c01b6e: 8221580: Confusing diagnostic for assigning a static final field in a constructor
  • c129ce4: 8300259: Add test coverage for processing of pending block files in signed JARs
  • b569742: 8301788: AlgorithmId should keep lowercase characters from 3rd party providers
  • 05ea083: 8301167: Update VerifySignedJar to actually exercise and test verification
  • ecf8842: 8300098: java/util/concurrent/ConcurrentHashMap/ConcurrentAssociateTest.java fails with internal timeout when executed with TieredCompilation1/3
  • 7ae447f: 8301095: [s390x] TestDwarf.java fails
  • 9c80b8a: 8299683: [S390X] Problems with -XX:+VerifyStack
  • ... and 15 more: https://git.openjdk.org/jdk/compare/d67bfe21a23fea2d9ef4eef4e811b774cca2ab94...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2023
@openjdk openjdk bot closed this Feb 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2023
@openjdk
Copy link

openjdk bot commented Feb 6, 2023

@honkar-jdk Pushed as commit 787e16b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants