8180387: com.sun.source.util.JavacTask should have a protected constructor.

[archiecobbs]

Standard practice is for constructors in abstract classes to be protected rather than public because they can't be used except from subclasses.

JDK-8180387 was filed to address a particular instance of this phenomenon in the class com.sun.source.util.JavacTask.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8180387: com.sun.source.util.JavacTask should have a protected constructor.

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12462/head:pull/12462
$ git checkout pull/12462

Update a local copy of the PR:
$ git checkout pull/12462
$ git pull https://git.openjdk.org/jdk pull/12462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12462

View PR using the GUI difftool:
$ git pr show -t 12462

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12462.diff

[bridgekeeper]

👋 Welcome back archiecobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0c2feea5)

[vicente-romero-oracle]

looks good

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8180387: com.sun.source.util.JavacTask should have a protected constructor.

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 246 new commits pushed to the master branch:

• a917fb3: 7033677: potential cast error in MemberEnter
• 6120319: 8302226: failure_handler native.core should wait for coredump to finish
• fef3eab: 8302734: Parallel: Remove unused LGRPSpace::_invalid_region
• ea5bfea: 8302661: Parallel: Remove PSVirtualSpace::is_aligned
• edf238b: 8302635: Race condition in HttpBodySubscriberWrapper when cancelling request
• cd77fcf: 8290822: C2: assert in PhaseIdealLoop::do_unroll() is subject to undefined behavior
• 57c9bc3: 8302335: IGV: Bytecode not showing
• 57fde75: 8302113: Improve CRC32 intrinsic with crypto pmull on AArch64
• b8c9d6c: 8302158: PPC: test/jdk/jdk/internal/vm/Continuation/Fuzz.java: AssertionError: res: false shouldPin: false
• dc55a7f: 8302202: Incorrect desugaring of null-allowed nested patterns
• ... and 236 more: https://git.openjdk.org/jdk/compare/960c3931337b314417ad33d8a775ee3e251692d7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vicente-romero-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[archiecobbs]

/integrate

[openjdk]

@archiecobbs
Your change (at version 0c2feea) is now ready to be sponsored by a Committer.

[vicente-romero-oracle]

/sponsor

[openjdk]

Going to push as commit b085ab9.
Since your change was applied there have been 641 commits pushed to the master branch:

• bfb812a: 8292818: replace 96-bit representation for field metadata with variable-sized streams
• 932be35: 8298469: Obsolete legacy parallel class loading workaround for non-parallel-capable class loaders
• 02a4ee2: 8303921: serviceability/sa/UniqueVtableTest.java timed out
• 4486f1b: 8304367: jlink --include-locales=* attempts to parse non .class resource files with classfile reader
• 8d2ebf2: 8303697: ProcessTools doesn't print last line of process output
• d5a1507: 8304314: StackWalkTest.java fails after CODETOOLS-7903373
• 384a8b8: 8303069: Memory leak in CompilerOracle::parse_from_line
• 6dd6c15: 8301684: Fix test code to not get finalizer deprecation warnings
• cb4ae19: 8292059: Do not inline InstanceKlass::allocate_instance()
• b2639e1: 8304164: jdk/classfile/CorpusTest.java still fails after JDK-8303910
• ... and 631 more: https://git.openjdk.org/jdk/compare/960c3931337b314417ad33d8a775ee3e251692d7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle @archiecobbs Pushed as commit b085ab9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.