-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8295425: Match the default priv exp length between SunPKCS11 and other JDK providers #12466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… when it's specified
👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into |
@valeriepeng The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@valeriepeng This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 300 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Any comment for release note: https://bugs.openjdk.org/browse/JDK-8303414? |
/integrate |
Going to push as commit 394eac8.
Your commit was automatically rebased without conflicts. |
@valeriepeng Pushed as commit 394eac8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This changes the SunPKCS11 provider to use the same default private exponent length as the value used by SunJCE provider when initializing the DH Key Pair Generator impl using key size. In addition, the generated key pair will contain the specified parameters. If the supplied parameter does not contain the optional private exponent length, then we will leave it to the underlying PKCS11 library.
Thanks in advance for the review~
Valerie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12466/head:pull/12466
$ git checkout pull/12466
Update a local copy of the PR:
$ git checkout pull/12466
$ git pull https://git.openjdk.org/jdk pull/12466/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12466
View PR using the GUI difftool:
$ git pr show -t 12466
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12466.diff