Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295425: Match the default priv exp length between SunPKCS11 and other JDK providers #12466

Closed
wants to merge 2 commits into from

Conversation

valeriepeng
Copy link

@valeriepeng valeriepeng commented Feb 8, 2023

This changes the SunPKCS11 provider to use the same default private exponent length as the value used by SunJCE provider when initializing the DH Key Pair Generator impl using key size. In addition, the generated key pair will contain the specified parameters. If the supplied parameter does not contain the optional private exponent length, then we will leave it to the underlying PKCS11 library.

Thanks in advance for the review~
Valerie


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295425: Match the default priv exp length between SunPKCS11 and other JDK providers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12466/head:pull/12466
$ git checkout pull/12466

Update a local copy of the PR:
$ git checkout pull/12466
$ git pull https://git.openjdk.org/jdk pull/12466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12466

View PR using the GUI difftool:
$ git pr show -t 12466

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12466.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 8, 2023

👋 Welcome back valeriep! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 8, 2023
@openjdk
Copy link

openjdk bot commented Feb 8, 2023

@valeriepeng The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 8, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 8, 2023

Webrevs

@valeriepeng valeriepeng changed the title 8295425: DH keys missing the optional private value length field even when it's specified 8295425: Parameters returned by DH keys should match the specified one in initialization Feb 28, 2023
@valeriepeng valeriepeng changed the title 8295425: Parameters returned by DH keys should match the specified one in initialization 8295425: Match the default priv exp length between SunPKCS11 and other JDK providers Feb 28, 2023
@openjdk
Copy link

openjdk bot commented Feb 28, 2023

@valeriepeng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295425: Match the default priv exp length between SunPKCS11 and other JDK providers

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 300 new commits pushed to the master branch:

  • 8815175: 8303216: Prefer ArrayList to LinkedList in sun.net.httpserver.ServerImpl
  • a10d5ac: 8303130: Document required Accessibility permissions on macOS
  • 50dc041: 8303227: JniObjWithEnv should be NullablePointer compliant
  • 61e8867: 8302040: Port fdlibm sqrt to Java
  • 6423065: 8303261: JFR: jdk/jfr/api/consumer/streaming/TestJVMCrash.java doesn't retry
  • dc5ea6a: 8303350: Fix mistyped {@code}
  • 4a415ad: 8303351: [IR Framework] Add missing cpu feature avx512bw after JDK-8302681
  • 30302d1: 8303250: Call ct_max_alignment_constraint using the base class
  • e144783: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls
  • 5feb13b: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened
  • ... and 290 more: https://git.openjdk.org/jdk/compare/2a579ab8392d30a35f044954178c788d16d4b800...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 28, 2023
@valeriepeng
Copy link
Author

Any comment for release note: https://bugs.openjdk.org/browse/JDK-8303414?

@valeriepeng
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2023

Going to push as commit 394eac8.
Since your change was applied there have been 315 commits pushed to the master branch:

  • 6e19387: 8303070: Memory leak in DCmdArgument<char*>::parse_value
  • 9fc518f: 8303401: Add a Vector API equalsIgnoreCase micro benchmark
  • 05faa73: 8303232: java.util.Date.parse(String) and java.util.Date(String) don't declare thrown IllegalArgumentException
  • 4c985e5: 8303183: Memory leak in Arguments::init_shared_archive_paths
  • 6af17c1: 8303362: Serial: Move CardTableRS to serial directory
  • c1e77e0: 8303252: G1: Return early from Full-GC if no regions are selected for compaction.
  • 8b86e1e: 8303344: After JDK-8302760, G1 heap verification does not exit VM after errors
  • 4c5d9cf: 8303013: Always do remembered set verification during G1 Full GC
  • 2451c5a: 8303357: [JVMCI] thread is _thread_in_vm when committing JFR compilation event
  • 539a495: 8302798: Refactor -XX:+UseOSErrorReporting for noreturn crash reporting
  • ... and 305 more: https://git.openjdk.org/jdk/compare/2a579ab8392d30a35f044954178c788d16d4b800...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2023
@openjdk openjdk bot closed this Mar 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 1, 2023
@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@valeriepeng Pushed as commit 394eac8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@valeriepeng valeriepeng deleted the JDK-8295425 branch March 3, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants