8301876: Crash in DumpTimeClassInfo::add_verification_constraint

[iklam]

When dumping the a dynamic CDS archive, we clone and restore the SystemDictionaryShared::_dumptime_table (see JDK-8264735.)

The bug is that for generated classes such as jdk/proxy2/$Proxy16 that are excluded from the CDS dump, we incorrectly remove their DumpTimeClassInfo from the _dumptime_table clone. After the dynamic archive has finished dumping, there's a very small window of time where some Java code would be executed and cause jdk/proxy2/$Proxy16 to be verified. This will cause the following crash because we can't find a DumpTimeClassInfo for this class.

DumpTimeSharedClassTable::get_info()
SystemDictionaryShared::get_info()
SystemDictionaryShared::add_verification_constraint()
VerificationType::is_reference_assignable_from()
ClassVerifier::verify_exception_handler_table()
ClassVerifier::verify_method()
ClassVerifier::verify_class()
Verifier::verify()
InstanceKlass::link_class_impl() -- for  jdk/proxy2/$Proxy16

The fix is simple -- always copy all DumpTimeClassInfo when cloning _dumptime_table .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301876: Crash in DumpTimeClassInfo::add_verification_constraint

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• Matias Saavedra Silva (@matias9927 - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12467/head:pull/12467
$ git checkout pull/12467

Update a local copy of the PR:
$ git checkout pull/12467
$ git pull https://git.openjdk.org/jdk pull/12467/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12467

View PR using the GUI difftool:
$ git pr show -t 12467

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12467.diff

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b09dc23f)

[calvinccheung]

LGTM

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301876: Crash in DumpTimeClassInfo::add_verification_constraint

Reviewed-by: ccheung, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 873558e: 8300914: Allow @ as an escape in documentation comments
• 8a9e383: 8301717: Remove obsolete jib profiles
• 631a279: 8301567: The test/jdk/java/awt/AppContext/ApplicationThreadsStop/java.policy is unused
• 638d612: 8298478: (fs) Path.of should allow input to include long path prefix
• 10dd98d: 8301462: Convert Permission files to use lambda after JDK-8076596
• 8d4c76d: 8302072: Parallel: Remove unimplemented ParCompactionManager::stack_push
• ecf21a9: 8301767: Convert virtual thread tests to JUnit
• 9af2ea2: 8301828: Avoid unnecessary array fill after creation in javax.swing.text
• 3db352d: 8302047: G1: Remove unused G1RegionToSpaceMapper::_region_granularity
• c92a7de: 8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java
• ... and 4 more: https://git.openjdk.org/jdk/compare/2a579ab8392d30a35f044954178c788d16d4b800...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

Nice and simple, LGTM!

[iklam]

Thanks @calvinccheung and @matias9927 for the review.

Passed tiers 1-4. The "Netty" test that I added (in closed repo) executed more than 20 times (on various platforms, 10 iterations each) without crashing.

/integrate

[openjdk]

Going to push as commit dc6d52c.
Since your change was applied there have been 14 commits pushed to the master branch:

• 873558e: 8300914: Allow @ as an escape in documentation comments
• 8a9e383: 8301717: Remove obsolete jib profiles
• 631a279: 8301567: The test/jdk/java/awt/AppContext/ApplicationThreadsStop/java.policy is unused
• 638d612: 8298478: (fs) Path.of should allow input to include long path prefix
• 10dd98d: 8301462: Convert Permission files to use lambda after JDK-8076596
• 8d4c76d: 8302072: Parallel: Remove unimplemented ParCompactionManager::stack_push
• ecf21a9: 8301767: Convert virtual thread tests to JUnit
• 9af2ea2: 8301828: Avoid unnecessary array fill after creation in javax.swing.text
• 3db352d: 8302047: G1: Remove unused G1RegionToSpaceMapper::_region_granularity
• c92a7de: 8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java
• ... and 4 more: https://git.openjdk.org/jdk/compare/2a579ab8392d30a35f044954178c788d16d4b800...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit dc6d52c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.