8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update

[kevinjwalls]

NotifReconnectDeadlockTest.java has been problemlisted for a long time (although 8042215 is the wrong bug id).

The originally reported problem ("No reconnection happened") cannot be reproduced, although there are occasional failures when the test is run.

Those failures are more like the connection failures fixed in similar tests (e.g. JDK-8227337), where:
java.rmi.NoSuchObjectException: no such object in table
..is reported, a startup issue, before the notification work, a failure to connect:
at java.management/javax.management.remote.JMXConnectorFactory.connect(JMXConnectorFactory.java:270)
at NotifReconnectDeadlockTest.main(NotifReconnectDeadlockTest.java:88)

We should do something similar here, but not such that it affects the deadlock timing. Increase serverTimeout, it needs a longer timeout to permit the initial connect to work reliably (fails occasionally, particularly but not exclusively on Windows debug builds). Not using the test library timeout scaling here as the timeout has to be kept fairly short, to let the test intentionally block the notification handler and try to cause the original issue.

Additional prints to make the test logs hopefully easier to follow, and tried to clarify a few comments that made no sense to me.

Passing on many runs on all platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12472/head:pull/12472
$ git checkout pull/12472

Update a local copy of the PR:
$ git checkout pull/12472
$ git pull https://git.openjdk.org/jdk pull/12472/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12472

View PR using the GUI difftool:
$ git pr show -t 12472

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12472.diff

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls The following labels will be automatically applied to this pull request:

• jmx
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (02cc17f1)

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update

Reviewed-by: cjplummer, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 8c87a67: 8245654: Add Certigna Root CA
• 97d0c87: 8302109: Trivial fixes to btree tests
• 0aeebee: 8301988: VerifyLiveClosure::verify_liveness asserts on bad pointers outside heap
• 4815566: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes
• 5147969: 8272288: Funky multiresolution image breaks graphics context
• 77ead44: 8302066: Counter _number_of_nmethods_with_dependencies should be atomic.
• f4b72df: 8282379: [LOOM] vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod011 sometimes fails
• 7fd440d: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation
• 7901f45: 8301260: Add system property to toggle XML Signature secure validation mode
• 597a9a4: 8301822: BasicLookAndFeel does not need to check for null after checking for type
• ... and 39 more: https://git.openjdk.org/jdk/compare/c61a38212e8d7ab8d9ece4c414dddd5032bfd6aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinjwalls]

Thanks!

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 1c7b09b.
Since your change was applied there have been 53 commits pushed to the master branch:

• 837d464: 8302125: Make G1 full gc abort the VM after failing VerifyDuringGC verification
• 723433d: 8302117: IgnoreUnrecognizedVMOptions flag causes failure in ArchiveHeapTestClass
• e245620: 8293198: [vectorapi] Improve the implementation of VectorMask.indexInRange()
• b814cfc: 8178806: Better exception logging in crypto code
• 8c87a67: 8245654: Add Certigna Root CA
• 97d0c87: 8302109: Trivial fixes to btree tests
• 0aeebee: 8301988: VerifyLiveClosure::verify_liveness asserts on bad pointers outside heap
• 4815566: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes
• 5147969: 8272288: Funky multiresolution image breaks graphics context
• 77ead44: 8302066: Counter _number_of_nmethods_with_dependencies should be atomic.
• ... and 43 more: https://git.openjdk.org/jdk/compare/c61a38212e8d7ab8d9ece4c414dddd5032bfd6aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 1c7b09b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.