-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8302214: Typo in javadoc of Arrays.compare and Arrays.mismatch #12488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… and Arrays.compare Javadocs
👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into |
Hello Eirik, I've create a JBS issue to track this change https://bugs.openjdk.org/browse/JDK-8302214. Please update the title of this PR to |
/issue 8302214 |
@eirbjo The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
Thanks, title changed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine to me.
@eirbjo This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 73 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit d782125.
Your commit was automatically rebased without conflicts. |
The Javadocs of Arrays.compare and Arrays.mismatch uses the incorrect capitalization
atoIndex
andbtoIndex
when referencing the correspondingaToIndex
andbToIndex
parameters.Sample:
This PR changes the capitalization to
aToIndex
andbToIndex
. This change was performed using case-sensitive search / replace in an IDE.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12488/head:pull/12488
$ git checkout pull/12488
Update a local copy of the PR:
$ git checkout pull/12488
$ git pull https://git.openjdk.org/jdk pull/12488/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12488
View PR using the GUI difftool:
$ git pr show -t 12488
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12488.diff