8302127: Remove unused arg in write_ref_field_post

[albertnetymk]

Trivial removing dead code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302127: Remove unused arg in write_ref_field_post

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12489/head:pull/12489
$ git checkout pull/12489

Update a local copy of the PR:
$ git checkout pull/12489
$ git pull https://git.openjdk.org/jdk pull/12489/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12489

View PR using the GUI difftool:
$ git pr show -t 12489

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12489.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8f3d7bc0)

[phohensee]

Lgtm.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302127: Remove unused arg in write_ref_field_post

Reviewed-by: phh, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

• 0c96584: 8301225: Replace NULL with nullptr in share/gc/shenandoah/
• 26b111d: 8301700: Increase the default TLS Diffie-Hellman group size from 1024-bit to 2048-bit
• 5238817: 8301463: Code in DatagramSocket still refers to resolved JDK-8237352
• 11194e8: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp
• 33bec20: 8300808: Accelerate Base64 on x86 for AVX2
• 46bcc49: 8302147: Speed up compiler/jvmci/compilerToVM/IterateFramesNative.java
• a9a53f4: 8302152: Speed up tests with infinite loops, sleep less
• 98a392c: 8302102: Disable ASan for SafeFetch and os::print_hex_dump
• 9ccf8ad: 8302129: Make MetaspaceReclaimPolicy a diagnostic switch
• bdcbafb: 8296344: Remove dependency on G1 for writing the CDS archive heap
• ... and 77 more: https://git.openjdk.org/jdk/compare/d4019820879ca11ebda53989fd46b08f3beb6424...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

So this function isn't applying the "same region" filter that's in the various other places. I wonder if
that's intentional, or a bug?

[albertnetymk]

It's safe because card-scanning is always prepared for "uninteresting" oops.

It's used only by Access API; its counterpart in interpreter/c1/c2 checks for null and cross-region additionally. It's not obvious whether the discrepancy is intentional or not though.

[kimbarrett]

Yeah, it looks okay. Not a hot path I think, so the additional optimization probably isn't important.

[kimbarrett]

Looks good.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 28f5250.
Since your change was applied there have been 87 commits pushed to the master branch:

• 0c96584: 8301225: Replace NULL with nullptr in share/gc/shenandoah/
• 26b111d: 8301700: Increase the default TLS Diffie-Hellman group size from 1024-bit to 2048-bit
• 5238817: 8301463: Code in DatagramSocket still refers to resolved JDK-8237352
• 11194e8: 8302325: Wrong comment in java.base/share/native/libjimage/imageFile.hpp
• 33bec20: 8300808: Accelerate Base64 on x86 for AVX2
• 46bcc49: 8302147: Speed up compiler/jvmci/compilerToVM/IterateFramesNative.java
• a9a53f4: 8302152: Speed up tests with infinite loops, sleep less
• 98a392c: 8302102: Disable ASan for SafeFetch and os::print_hex_dump
• 9ccf8ad: 8302129: Make MetaspaceReclaimPolicy a diagnostic switch
• bdcbafb: 8296344: Remove dependency on G1 for writing the CDS archive heap
• ... and 77 more: https://git.openjdk.org/jdk/compare/d4019820879ca11ebda53989fd46b08f3beb6424...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 28f5250.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.