8250914: Matcher::stack_direction() is unused

[robcasloz]

Remove unused Matcher::stack_direction() together with related ADL entries and
ADLC support.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8250914: Matcher::stack_direction() is unused

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/125/head:pull/125
$ git checkout pull/125

[bridgekeeper]

Hi @robcasloz, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user robcasloz" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[robcasloz]

/covered

[openjdk]

@robcasloz The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[iwanowww]

Looks good.

[openjdk]

@robcasloz This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8250914: Matcher::stack_direction() is unused

Remove unused Matcher::stack_direction() together with related ADL entries and
ADLC support.

Reviewed-by: vlivanov, thartmann

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 24 commits pushed to the master branch:

• 9687dca: 8252494: C2: TypeAryPtr::cast_to_autobox_cache does not use ptr_type
• 8777ded: 8253008: Remove develop flags TraceLongCompiles/LongCompileThreshold
• c7062dc: 8253026: Remove dummy call to gc alot from VM Thread
• 5144190: 8243208: Clean up JVMFlag implementation
• 976acdd: 8252406: Introduce Thread::as_Java_thread() convenience function
• 4880226: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
• 8da6c8d: 7183828: Invalid Image Variant when using anything other than BufferedImage
• ff21696: 8252817: Cleanup the classes in the java.awt.color package
• 44a74da: 8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError
• 418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/c98417ebca5cf4cb329aedee40267f32a4ae9353...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 9687dcabb65e5d0bad873290550a2b4cffa0eebc.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@iwanowww, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (e92ff3f)

[TobiHartmann]

Looks good to me.

[robcasloz]

Thanks Vladimir and Tobias!

[robcasloz]

/summary
Remove unused Matcher::stack_direction() together with related ADL entries and
ADLC support.

[openjdk]

@robcasloz Setting summary to:

Remove unused Matcher::stack_direction() together with related ADL entries and
ADLC support.

[robcasloz]

/integrate

[openjdk]

@robcasloz
Your change (at version e92ff3f) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

@TobiHartmann @robcasloz Since your change was applied there have been 24 commits pushed to the master branch:

• 9687dca: 8252494: C2: TypeAryPtr::cast_to_autobox_cache does not use ptr_type
• 8777ded: 8253008: Remove develop flags TraceLongCompiles/LongCompileThreshold
• c7062dc: 8253026: Remove dummy call to gc alot from VM Thread
• 5144190: 8243208: Clean up JVMFlag implementation
• 976acdd: 8252406: Introduce Thread::as_Java_thread() convenience function
• 4880226: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
• 8da6c8d: 7183828: Invalid Image Variant when using anything other than BufferedImage
• ff21696: 8252817: Cleanup the classes in the java.awt.color package
• 44a74da: 8252919: JDK built with --enable-cds=no fails with NoClassDefFoundError
• 418e4a2: 8252830: Correct missing javadoc comments in java.rmi module
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/c98417ebca5cf4cb329aedee40267f32a4ae9353...master

Your commit was automatically rebased without conflicts.

Pushed as commit 040c8f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.