8178806: Better exception logging in crypto code

[driverkt]

Updated this template file to not fail silently on canUseProvider check in debug mode to provide additional information to aid in debugging.

See: https://bugs.openjdk.org/browse/JDK-8178806

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8178806: Better exception logging in crypto code

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12504/head:pull/12504
$ git checkout pull/12504

Update a local copy of the PR:
$ git checkout pull/12504
$ git pull https://git.openjdk.org/jdk pull/12504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12504

View PR using the GUI difftool:
$ git pr show -t 12504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12504.diff

[driverkt]

/issue add 8178806

[bridgekeeper]

👋 Welcome back kdriver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@driverkt This issue is referenced in the PR title - it will now be updated.

[openjdk]

@driverkt The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d73df1b2)
• 00: Full (517ab671)

[valeriepeng]

line 239 and 240 can be combined into one line?

[driverkt]

I thought about this, but logically they are not related...

I can definitely combine, but I made this choice for readability. What do you think?

[driverkt]

resolved

[valeriepeng]

Also, may just rely on the toString() impl instead of separate handling of getClass() and getMessage()?

[driverkt]

That change was already in the previous commit.

[valeriepeng]

add noreg-xxx label to the bug record since there is no regression test?

[openjdk]

@driverkt This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8178806: Better exception logging in crypto code

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 8c87a67: 8245654: Add Certigna Root CA
• 97d0c87: 8302109: Trivial fixes to btree tests
• 0aeebee: 8301988: VerifyLiveClosure::verify_liveness asserts on bad pointers outside heap
• 4815566: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes
• 5147969: 8272288: Funky multiresolution image breaks graphics context
• 77ead44: 8302066: Counter _number_of_nmethods_with_dependencies should be atomic.
• f4b72df: 8282379: [LOOM] vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod011 sometimes fails
• 7fd440d: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@valeriepeng) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[driverkt]

/integrate

[openjdk]

@driverkt
Your change (at version d73df1b) is now ready to be sponsored by a Committer.

[valeriepeng]

/sponsor

[openjdk]

Going to push as commit b814cfc.
Since your change was applied there have been 8 commits pushed to the master branch:

• 8c87a67: 8245654: Add Certigna Root CA
• 97d0c87: 8302109: Trivial fixes to btree tests
• 0aeebee: 8301988: VerifyLiveClosure::verify_liveness asserts on bad pointers outside heap
• 4815566: 8228604: StackMapFrames are missing from redefined class bytes of retransformed classes
• 5147969: 8272288: Funky multiresolution image breaks graphics context
• 77ead44: 8302066: Counter _number_of_nmethods_with_dependencies should be atomic.
• f4b72df: 8282379: [LOOM] vmTestbase/nsk/jdi/ClassType/invokeMethod/invokemethod011 sometimes fails
• 7fd440d: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation

Your commit was automatically rebased without conflicts.

[openjdk]

@valeriepeng @driverkt Pushed as commit b814cfc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.