6595142: (spec) ByteArrayInputStream treats bytes, not characters

[bplb]

Replace the two occurrences of character with byte.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6595142: (spec) ByteArrayInputStream treats bytes, not characters

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12505/head:pull/12505
$ git checkout pull/12505

Update a local copy of the PR:
$ git checkout pull/12505
$ git pull https://git.openjdk.org/jdk pull/12505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12505

View PR using the GUI difftool:
$ git pr show -t 12505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12505.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7868641a)
• 00: Full (b4e6bf83)

[AlanBateman]

Looks okay, I assume you've done a wider search to see if there are any more.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6595142: (spec) ByteArrayInputStream treats bytes, not characters

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• 4539899: 8301480: Replace NULL with nullptr in os/posix
• 1428db7: 8301224: Replace NULL with nullptr in share/gc/shared/
• c25b4f4: 8301578: Perform output outside synchronization in Module.class
• 5830c03: 8302004: InlineTree should consult replay file in release build
• c8ace48: 8301072: Replace NULL with nullptr in share/oops/
• 1c7b09b: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• 837d464: 8302125: Make G1 full gc abort the VM after failing VerifyDuringGC verification
• 723433d: 8302117: IgnoreUnrecognizedVMOptions flag causes failure in ArchiveHeapTestClass
• e245620: 8293198: [vectorapi] Improve the implementation of VectorMask.indexInRange()
• b814cfc: 8178806: Better exception logging in crypto code
• ... and 30 more: https://git.openjdk.org/jdk/compare/638d612c6b7c08c1f7be0d4e75e9f8a6dca1ef19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[djelinski]

There are similar incorrect comments in SequenceInputStream and BufferedInputStream. There could be others, but "character" is a very popular word, so they are hard to spot.

[bplb]

There are similar incorrect comments in SequenceInputStream and BufferedInputStream. There could be others, but "character" is a very popular word, so they are hard to spot.

Thanks for spotting these. Fixed in 7868641.

[bplb]

Looks okay, I assume you've done a wider search to see if there are any more.

I missed the ones that @djelinski spotted. I rescanned java.io and don't see any others. Those two are fixed by 7868641.

[bplb]

/integrate

[openjdk]

Going to push as commit 57798dd.
Since your change was applied there have been 43 commits pushed to the master branch:

• 880f52f: 8301638: A number of nsk/jdi invokemethod tests should be converted to create virtual threads
• db1b48e: 8302167: Avoid allocating register in fast_lock()
• 582b943: 8278965: crash in SymbolTable::do_lookup
• 4539899: 8301480: Replace NULL with nullptr in os/posix
• 1428db7: 8301224: Replace NULL with nullptr in share/gc/shared/
• c25b4f4: 8301578: Perform output outside synchronization in Module.class
• 5830c03: 8302004: InlineTree should consult replay file in release build
• c8ace48: 8301072: Replace NULL with nullptr in share/oops/
• 1c7b09b: 8302069: javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java update
• 837d464: 8302125: Make G1 full gc abort the VM after failing VerifyDuringGC verification
• ... and 33 more: https://git.openjdk.org/jdk/compare/638d612c6b7c08c1f7be0d4e75e9f8a6dca1ef19...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 57798dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.