8302203: IR framework should detect non-compilable test methods early

[TobiHartmann]

If a test method becomes non-compilable due to compilation bailouts, the IR framework will currently try to re-enqueue the method for compilation until the 10s timeout is reached (see log in bug report). Instead, we should check if the method became non-compilable and bail out immediately.

Thanks,
Tobias

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302203: IR framework should detect non-compilable test methods early

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12510/head:pull/12510
$ git checkout pull/12510

Update a local copy of the PR:
$ git checkout pull/12510
$ git pull https://git.openjdk.org/jdk pull/12510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12510

View PR using the GUI difftool:
$ git pr show -t 12510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12510.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0c6c23a0)

[chhagedorn]

Looks good!

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302203: IR framework should detect non-compilable test methods early

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 84e4799: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
• 57798dd: 6595142: (spec) ByteArrayInputStream treats bytes, not characters
• 880f52f: 8301638: A number of nsk/jdi invokemethod tests should be converted to create virtual threads
• db1b48e: 8302167: Avoid allocating register in fast_lock()
• 582b943: 8278965: crash in SymbolTable::do_lookup
• 4539899: 8301480: Replace NULL with nullptr in os/posix
• 1428db7: 8301224: Replace NULL with nullptr in share/gc/shared/
• c25b4f4: 8301578: Perform output outside synchronization in Module.class
• 5830c03: 8302004: InlineTree should consult replay file in release build
• c8ace48: 8301072: Replace NULL with nullptr in share/oops/

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Thanks for the review, Christian!

[vnkozlov]

Good.

[TobiHartmann]

Thanks, Vladimir!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit d1c87a0.
Since your change was applied there have been 19 commits pushed to the master branch:

• 1fec6b5: 8301852: RISC-V: Optimize class atomic when order is memory_order_relaxed
• 7c233bc: 8302114: RISC-V: Several foreign jtreg tests fail with debug build after JDK-8301818
• 8049e59: 8301833: Add wide-ranging tests for FDLIBM porting
• 6a44120: 8301269: Update Commons BCEL to Version 6.7.0
• 6f9f2b5: 8301737: java/rmi/server/UnicastRemoteObject/serialFilter/FilterUROTest.java fail with -Xcomp
• 1ef9f65: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline
• 74b167b: 8301819: Enable continuations code by default
• 919a6da: 8301202: Port fdlibm log to Java
• 98e98e9: 8296322: javac: use methods to manage parser mode flags
• 84e4799: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
• ... and 9 more: https://git.openjdk.org/jdk/compare/1c7b09bc23ac37f83b9043de35b71bea7e814da5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit d1c87a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.