8301627: System.exit and Runtime.exit debug logging #12517

RogerRiggs · 2023-02-10T20:33:39Z

It can be difficult to find the cause of calls to java.lang.System.exit(status) and Runtime.exit(status) because the Java runtime exits.
The status value and stack trace are logged using the System Logger named java.lang.Runtime with message level System.Logger.Level.DEBUG.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8302691 to be approved

Issues

JDK-8301627: System.exit and Runtime.exit debug logging
JDK-8302691: System.exit and Runtime.exit debug logging (CSR)

Reviewers

Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 3dc13135
Chris Hegarty (@ChrisHegarty - Reviewer) ⚠️ Review applies to 3dc13135

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12517/head:pull/12517
$ git checkout pull/12517

Update a local copy of the PR:
$ git checkout pull/12517
$ git pull https://git.openjdk.org/jdk pull/12517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12517

View PR using the GUI difftool:
$ git pr show -t 12517

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12517.diff

…Runtime".

bridgekeeper · 2023-02-10T20:35:28Z

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-02-10T20:38:00Z

@RogerRiggs The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-02-10T21:20:59Z

Webrevs

src/java.base/share/classes/java/lang/Shutdown.java

test/jdk/java/lang/runtime/RuntimeExitLogTest.java

…System.exit. Added test case with console logger (when java.util.logging) not present. Removed @implNote tag its not appropriate in implementation javadoc. Still looking into when and where the log configuration should be described.

…gging.

src/java.base/share/classes/java/lang/Runtime.java

src/java.base/share/classes/java/lang/Shutdown.java

src/java.base/share/classes/java/lang/Runtime.java

AlanBateman · 2023-02-17T07:46:28Z

I see the test is added to test/jdk/java/lang/runtime but that is the tests for java.lang.runtime. The tests for java.lang.Runtime were moved to test/jdk/java/lang/RuntimeTests at some point. So I think the new test should move there.

src/java.base/share/classes/java/lang/Shutdown.java

src/java.base/share/classes/java/lang/Runtime.java

Added implNote to System.exit. A few javadoc updates for review comments.

openjdk · 2023-02-17T22:14:32Z

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301627: System.exit and Runtime.exit debug logging

Reviewed-by: alanb, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

9a79722: 8299234: JMX Repository.query performance
e47e9ec: 8300658: memory_and_swap_limit() reporting wrong values on systems with swapaccount=0
7cf7e0a: 8302070: Factor null-check into load_klass() calls
e731695: 8302882: Newly added test javax/swing/JFileChooser/JFileChooserFontReset.java fails with HeadlessException
b5a7426: 8301749: Tracking malloc pooled memory size
6ac5e05: 8302068: Serial: Refactor oop closures used in Young GC
71cf7c4: 8302518: Add missing Op_RoundDoubleMode in VectorNode::vector_operands()
98716e2: 8302709: Remove explicit remembered set verification in G1
303c61f: 8302776: RISC-V: Fix typo CSR_INSTERT to CSR_INSTRET
7c40c8a: 8302312: Make ParGCRareEvent_lock G1 specific
... and 20 more: https://git.openjdk.org/jdk/compare/6120319afdba98b5ff547b870a0260479e8b683c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

ChrisHegarty

I left one trivial comment relating to a typo, but otherwise LGTM.

src/java.base/share/classes/java/lang/Runtime.java

RogerRiggs · 2023-02-21T15:36:16Z

/integrate

openjdk · 2023-02-21T15:37:18Z

Going to push as commit 10b4cc9.
Since your change was applied there have been 52 commits pushed to the master branch:

db483a3: 8302320: AsyncGetCallTrace obtains too few frames in sanity test
02eb240: 8302846: IGV: Zoom stuck when zooming out on large graphs
92dfa11: 8302863: Speed up String::encodeASCII using countPositives
8b20aa9: 8302981: Fix a typo in the doc comment for java.lang.Record.equals
644fe0a: 8302837: Kernel32.cpp array memory release invokes undefined behaviour
60e6378: 8302977: ZGC: Doesn't support gc/TestVerifySubSet.java
fef1910: 8299777: Test runtime/NMT/BaselineWithParameter.java timed out
622f560: 8302886: Parallel: Remove unimplemented methods in ParCompactionManager
9fd77c7: 8302868: Serial: Remove CardTableRS::initialize
f35cf79: 8302867: G1: Removing unused variable in G1CardTable::initialize
... and 42 more: https://git.openjdk.org/jdk/compare/6120319afdba98b5ff547b870a0260479e8b683c...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-02-21T15:37:30Z

@RogerRiggs Pushed as commit 10b4cc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

RogerRiggs added 2 commits February 9, 2023 18:04

Add logging of calls to Runtime.exit to the system logger "java.lang.…

e9287ed

…Runtime".

Locate the System logger before taking the shutdown lock

7f14991

openjdk bot added the rfr Pull request is ready for review label Feb 10, 2023

openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 10, 2023

AlanBateman reviewed Feb 12, 2023

View reviewed changes

src/java.base/share/classes/java/lang/Shutdown.java Outdated Show resolved Hide resolved

AlanBateman reviewed Feb 12, 2023

View reviewed changes

test/jdk/java/lang/runtime/RuntimeExitLogTest.java Show resolved Hide resolved

RogerRiggs added 2 commits February 13, 2023 18:29

Add an @implNote to Runtime.exit to describe the java.lang.Runtime lo…

a8eca9e

…gging.

dfuch reviewed Feb 14, 2023

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

Correct System.getLogger link

6012354

stuart-marks reviewed Feb 14, 2023

View reviewed changes

src/java.base/share/classes/java/lang/Shutdown.java Show resolved Hide resolved

seanjmullan reviewed Feb 16, 2023

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

seanjmullan reviewed Feb 16, 2023

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

openjdk bot added the csr Pull request needs approved CSR before integration label Feb 16, 2023

Improve implNote for Runtime.exit() with review suggestions.

a31645c

AlanBateman reviewed Feb 17, 2023

View reviewed changes

src/java.base/share/classes/java/lang/Shutdown.java Show resolved Hide resolved

AlanBateman reviewed Feb 17, 2023

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Show resolved Hide resolved

RogerRiggs added 2 commits February 17, 2023 10:58

Merge branch 'master' into 8301627-log-system-exit

3d68113

Move test to the java/lang/RuntimeTests directory.

3dc1313

Added implNote to System.exit. A few javadoc updates for review comments.

AlanBateman approved these changes Feb 17, 2023

View reviewed changes

openjdk bot removed the csr Pull request needs approved CSR before integration label Feb 17, 2023

openjdk bot added the ready Pull request is ready to be integrated label Feb 17, 2023

ChrisHegarty approved these changes Feb 20, 2023

View reviewed changes

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved

fix double the

acce58f

openjdk bot added the integrated Pull request has been integrated label Feb 21, 2023

openjdk bot closed this Feb 21, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2023

RogerRiggs deleted the 8301627-log-system-exit branch December 11, 2023 17:24

8301627: System.exit and Runtime.exit debug logging #12517

8301627: System.exit and Runtime.exit debug logging #12517

Uh oh!

Conversation

RogerRiggs commented Feb 10, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issues

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Feb 10, 2023

Uh oh!

openjdk bot commented Feb 10, 2023

Uh oh!

mlbridge bot commented Feb 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlanBateman commented Feb 17, 2023

Uh oh!

Uh oh!

Uh oh!

openjdk bot commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChrisHegarty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RogerRiggs commented Feb 21, 2023

Uh oh!

openjdk bot commented Feb 21, 2023

Uh oh!

openjdk bot commented Feb 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

RogerRiggs commented Feb 10, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 10, 2023 •

edited

Loading

openjdk bot commented Feb 17, 2023 •

edited

Loading