Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301627: System.exit and Runtime.exit debug logging #12517

Closed
wants to merge 9 commits into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Feb 10, 2023

It can be difficult to find the cause of calls to java.lang.System.exit(status) and Runtime.exit(status) because the Java runtime exits.
The status value and stack trace are logged using the System Logger named java.lang.Runtime with message level System.Logger.Level.DEBUG.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8302691 to be approved

Issues

  • JDK-8301627: System.exit and Runtime.exit debug logging
  • JDK-8302691: System.exit and Runtime.exit debug logging (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12517/head:pull/12517
$ git checkout pull/12517

Update a local copy of the PR:
$ git checkout pull/12517
$ git pull https://git.openjdk.org/jdk pull/12517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12517

View PR using the GUI difftool:
$ git pr show -t 12517

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12517.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 10, 2023

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 10, 2023
@openjdk
Copy link

openjdk bot commented Feb 10, 2023

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 10, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 10, 2023

…System.exit.

Added test case with console logger (when java.util.logging) not present.
Removed @implNote tag its not appropriate in implementation javadoc.
Still looking into when and where the log configuration should be described.
@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Feb 16, 2023
@AlanBateman
Copy link
Contributor

I see the test is added to test/jdk/java/lang/runtime but that is the tests for java.lang.runtime. The tests for java.lang.Runtime were moved to test/jdk/java/lang/RuntimeTests at some point. So I think the new test should move there.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Feb 17, 2023
@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301627: System.exit and Runtime.exit debug logging

Reviewed-by: alanb, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 9a79722: 8299234: JMX Repository.query performance
  • e47e9ec: 8300658: memory_and_swap_limit() reporting wrong values on systems with swapaccount=0
  • 7cf7e0a: 8302070: Factor null-check into load_klass() calls
  • e731695: 8302882: Newly added test javax/swing/JFileChooser/JFileChooserFontReset.java fails with HeadlessException
  • b5a7426: 8301749: Tracking malloc pooled memory size
  • 6ac5e05: 8302068: Serial: Refactor oop closures used in Young GC
  • 71cf7c4: 8302518: Add missing Op_RoundDoubleMode in VectorNode::vector_operands()
  • 98716e2: 8302709: Remove explicit remembered set verification in G1
  • 303c61f: 8302776: RISC-V: Fix typo CSR_INSTERT to CSR_INSTRET
  • 7c40c8a: 8302312: Make ParGCRareEvent_lock G1 specific
  • ... and 20 more: https://git.openjdk.org/jdk/compare/6120319afdba98b5ff547b870a0260479e8b683c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 17, 2023
Copy link
Member

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one trivial comment relating to a typo, but otherwise LGTM.

src/java.base/share/classes/java/lang/Runtime.java Outdated Show resolved Hide resolved
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 21, 2023

Going to push as commit 10b4cc9.
Since your change was applied there have been 52 commits pushed to the master branch:

  • db483a3: 8302320: AsyncGetCallTrace obtains too few frames in sanity test
  • 02eb240: 8302846: IGV: Zoom stuck when zooming out on large graphs
  • 92dfa11: 8302863: Speed up String::encodeASCII using countPositives
  • 8b20aa9: 8302981: Fix a typo in the doc comment for java.lang.Record.equals
  • 644fe0a: 8302837: Kernel32.cpp array memory release invokes undefined behaviour
  • 60e6378: 8302977: ZGC: Doesn't support gc/TestVerifySubSet.java
  • fef1910: 8299777: Test runtime/NMT/BaselineWithParameter.java timed out
  • 622f560: 8302886: Parallel: Remove unimplemented methods in ParCompactionManager
  • 9fd77c7: 8302868: Serial: Remove CardTableRS::initialize
  • f35cf79: 8302867: G1: Removing unused variable in G1CardTable::initialize
  • ... and 42 more: https://git.openjdk.org/jdk/compare/6120319afdba98b5ff547b870a0260479e8b683c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2023
@openjdk openjdk bot closed this Feb 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2023
@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@RogerRiggs Pushed as commit 10b4cc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8301627-log-system-exit branch December 11, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
6 participants