JDK-8297031: IGV: Copy extracted nodes and layout for cloned graph

[tobiasholenstein]

previously in IGV the user could open a graph in a new tab by right clicking on a graph -> "open clone". Unfortunately, this did not open a "real" clone if the graph was already opened in another tab: Neither the extracted nodes nor the chosen layout (sea, block, cfg) were applied to the new tab.

Solution

1. "open clone" was renamed to "Open in new tab"

2. The user can right click a Tab -> "Clone" . This opens a proper clone with the same extracted nodes and the chosen layout

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297031: IGV: Copy extracted nodes and layout for cloned graph

Reviewers

• Roberto Castañeda Lozano (@robcasloz - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12534/head:pull/12534
$ git checkout pull/12534

Update a local copy of the PR:
$ git checkout pull/12534
$ git pull https://git.openjdk.org/jdk pull/12534/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12534

View PR using the GUI difftool:
$ git pr show -t 12534

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12534.diff

[bridgekeeper]

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tobiasholenstein The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (b7521528)
• 02: Full - Incremental (fa1ff117)
• 01: Full - Incremental (12ca33dc)
• 00: Full (0276b4dc)

[robcasloz]

Thanks for fixing this, Toby! I tried it out and works as expected. Just a suggestion: if it is not too difficult to implement, it would be a nice usability improvement to disable Open in new tab when Open would already open the graph in a new tab (i.e. when no graph in the same group is opened).

[openjdk]

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297031: IGV: Copy extracted nodes and layout for cloned graph

Reviewed-by: rcastanedalo, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 478 new commits pushed to the master branch:

• 53ae4c0: 8300645: Handle julong values in logging of GET_CONTAINER_INFO macros
• c77f644: 8302625: Bad copyright line after JDK-8302385
• 519229d: 8302385: Remove MetaspaceReclaimPolicy=none
• 6e2d3c6: 8302455: VM.classloader_stats memory size values are wrong
• 1480d41: 8208470: Type annotations on inner type that is an array component
• 573c316: 8224980: FLAG_SET_ERGO silently ignores invalid values
• 3ba1560: 8302026: Port fdlibm inverse trig functions (asin, acos, atan) to Java
• 861e302: 8302163: Speed up various String comparison methods with ArraysSupport.mismatch
• 50dcc2a: 8301460: Clean up LambdaForm to reference BasicType enums directly
• 28f5250: 8302127: Remove unused arg in write_ref_field_post
• ... and 468 more: https://git.openjdk.org/jdk/compare/85d8bacb0ff4015941db53305e6a0d5d28391e1f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tobiasholenstein]

Thanks for fixing this, Toby! I tried it out and works as expected. Just a suggestion: if it is not too difficult to implement, it would be a nice usability improvement to disable Open in new tab when Open would already open the graph in a new tab (i.e. when no graph in the same group is opened).

Sure! I updated the PR. Now Open in new tab only shows if a graph in the same group is already opened.

[robcasloz]

Looks good, thanks!

[TobiHartmann]

Looks good to me and works nicely in the scenarios that I tested.

[tobiasholenstein]

Thanks @robcasloz and @TobiHartmann for the reviews!

/integrate

[openjdk]

Going to push as commit e045af4.
Since your change was applied there have been 478 commits pushed to the master branch:

• 53ae4c0: 8300645: Handle julong values in logging of GET_CONTAINER_INFO macros
• c77f644: 8302625: Bad copyright line after JDK-8302385
• 519229d: 8302385: Remove MetaspaceReclaimPolicy=none
• 6e2d3c6: 8302455: VM.classloader_stats memory size values are wrong
• 1480d41: 8208470: Type annotations on inner type that is an array component
• 573c316: 8224980: FLAG_SET_ERGO silently ignores invalid values
• 3ba1560: 8302026: Port fdlibm inverse trig functions (asin, acos, atan) to Java
• 861e302: 8302163: Speed up various String comparison methods with ArraysSupport.mismatch
• 50dcc2a: 8301460: Clean up LambdaForm to reference BasicType enums directly
• 28f5250: 8302127: Remove unused arg in write_ref_field_post
• ... and 468 more: https://git.openjdk.org/jdk/compare/85d8bacb0ff4015941db53305e6a0d5d28391e1f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tobiasholenstein Pushed as commit e045af4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.