8302464: Parallel: Remove unreachable code in callers of numa_has_static_binding

[albertnetymk]

Trivial removing dead code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302464: Parallel: Remove unreachable code in callers of numa_has_static_binding

Reviewers

• Leo Korinth (@lkorinth - Reviewer)
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12559/head:pull/12559
$ git checkout pull/12559

Update a local copy of the PR:
$ git checkout pull/12559
$ git pull https://git.openjdk.org/jdk pull/12559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12559

View PR using the GUI difftool:
$ git pr show -t 12559

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12559.diff

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (30c6ee70)
• 00: Full (2c8c5c31)

[lkorinth]

I can not see the removal of os::numa_has_static_binding() itself, only the usage of it.

[albertnetymk]

Removing an os API can be controversial (even if it's unused), so I kept it outside of this gc-only PR.

[lkorinth]

Removing an os API can be controversial (even if it's unused), so I kept it outside of this gc-only PR.

If we are to support non static NUMA bindings, the predicate method is itself easier to restore than the code we now remove. If we remove it in this fix, we can later easier see the context of why the predicate was removed, and what it was used for. It will be easier to follow version control history. If we have no non-gc users of this method, I think we can see it as effecting gc only.

[lkorinth]

Looks great, thanks for removing the method as well. I will create an investigation enhancement to see if MutableNUMASpace::update() can be removed as well. Approved!

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302464: Parallel: Remove unreachable code in callers of numa_has_static_binding

Reviewed-by: lkorinth, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 53ae4c0: 8300645: Handle julong values in logging of GET_CONTAINER_INFO macros
• c77f644: 8302625: Bad copyright line after JDK-8302385
• 519229d: 8302385: Remove MetaspaceReclaimPolicy=none
• 6e2d3c6: 8302455: VM.classloader_stats memory size values are wrong
• 1480d41: 8208470: Type annotations on inner type that is an array component
• 573c316: 8224980: FLAG_SET_ERGO silently ignores invalid values
• 3ba1560: 8302026: Port fdlibm inverse trig functions (asin, acos, atan) to Java
• 861e302: 8302163: Speed up various String comparison methods with ArraysSupport.mismatch
• 50dcc2a: 8301460: Clean up LambdaForm to reference BasicType enums directly
• 28f5250: 8302127: Remove unused arg in write_ref_field_post
• ... and 19 more: https://git.openjdk.org/jdk/compare/8c2c8b3f7f1bf286ca67a736938797d14fd7555c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lkorinth]

Looks great, thanks for removing the method as well. I will create an investigation enhancement to see if MutableNUMASpace::update() can be removed as well. Approved!

https://bugs.openjdk.org/browse/JDK-8302581 Parallel: Investigate if MutableNUMASpace::update() can be removed

[tschatzl]

Lgtm.

[albertnetymk]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 687a461.
Since your change was applied there have been 31 commits pushed to the master branch:

• 84c058b: 8300549: JFileChooser Approve button tooltip is null in Aqua L&F in CUSTOM_DIALOG mode
• e045af4: 8297031: IGV: Copy extracted nodes and layout for cloned graph
• 53ae4c0: 8300645: Handle julong values in logging of GET_CONTAINER_INFO macros
• c77f644: 8302625: Bad copyright line after JDK-8302385
• 519229d: 8302385: Remove MetaspaceReclaimPolicy=none
• 6e2d3c6: 8302455: VM.classloader_stats memory size values are wrong
• 1480d41: 8208470: Type annotations on inner type that is an array component
• 573c316: 8224980: FLAG_SET_ERGO silently ignores invalid values
• 3ba1560: 8302026: Port fdlibm inverse trig functions (asin, acos, atan) to Java
• 861e302: 8302163: Speed up various String comparison methods with ArraysSupport.mismatch
• ... and 21 more: https://git.openjdk.org/jdk/compare/8c2c8b3f7f1bf286ca67a736938797d14fd7555c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 687a461.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.