8298276: JFR: Update NMT events to make use of common periodic timestamp feature

[egahlin]

Could I have review of a change that ensures NMT events use the same timestamp.

Testing: tier1, tier2, jdk/jdk/jfr/*

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298276: JFR: Update NMT events to make use of common periodic timestamp feature

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12564/head:pull/12564
$ git checkout pull/12564

Update a local copy of the PR:
$ git checkout pull/12564
$ git pull https://git.openjdk.org/jdk pull/12564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12564

View PR using the GUI difftool:
$ git pr show -t 12564

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12564.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[egahlin]

/label remove hotspot
/label add hotspot-jfr

[openjdk]

@egahlin
The hotspot label was successfully removed.

[openjdk]

@egahlin
The hotspot-jfr label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (8256a8e5)
• 00: Full (387c8087)

[mgronlun]

Nice!

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298276: JFR: Update NMT events to make use of common periodic timestamp feature

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 687a461: 8302464: Parallel: Remove unreachable code in callers of numa_has_static_binding
• 84c058b: 8300549: JFileChooser Approve button tooltip is null in Aqua L&F in CUSTOM_DIALOG mode
• e045af4: 8297031: IGV: Copy extracted nodes and layout for cloned graph
• 53ae4c0: 8300645: Handle julong values in logging of GET_CONTAINER_INFO macros
• c77f644: 8302625: Bad copyright line after JDK-8302385
• 519229d: 8302385: Remove MetaspaceReclaimPolicy=none
• 6e2d3c6: 8302455: VM.classloader_stats memory size values are wrong
• 1480d41: 8208470: Type annotations on inner type that is an array component
• 573c316: 8224980: FLAG_SET_ERGO silently ignores invalid values
• 3ba1560: 8302026: Port fdlibm inverse trig functions (asin, acos, atan) to Java
• ... and 19 more: https://git.openjdk.org/jdk/compare/8933c2d06a60671c2a4c6a683183f3979732350c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit f558a6c.
Since your change was applied there have been 34 commits pushed to the master branch:

• a58fa6e: 8302514: Misleading error generated when empty class file encountered
• 3cc459b: 8302595: use-after-free related to GraphKit::clone_map
• 2e3cea0: 8302594: use-after-free in Node::destruct
• 9b911b4: 8301959: Compile command in compiler.loopopts.TestRemoveEmptyCountedLoop does not work
• c29a136: 8291735: methods_do() always run at exit
• 687a461: 8302464: Parallel: Remove unreachable code in callers of numa_has_static_binding
• 84c058b: 8300549: JFileChooser Approve button tooltip is null in Aqua L&F in CUSTOM_DIALOG mode
• e045af4: 8297031: IGV: Copy extracted nodes and layout for cloned graph
• 53ae4c0: 8300645: Handle julong values in logging of GET_CONTAINER_INFO macros
• c77f644: 8302625: Bad copyright line after JDK-8302385
• ... and 24 more: https://git.openjdk.org/jdk/compare/8933c2d06a60671c2a4c6a683183f3979732350c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit f558a6c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.