Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8301959: Compile command in compiler.loopopts.TestRemoveEmptyCountedLoop does not work #12575

Closed

Conversation

tobiasholenstein
Copy link
Member

@tobiasholenstein tobiasholenstein commented Feb 15, 2023

TestRemoveEmptyCountedLoop.java used an asterisk operator in CompileOnly which is not supported:
-XX:CompileOnly=compiler.loopopts.TestRemoveEmptyCountedLoop::test*

Solution

Changed the test to use -XX:CompileCommand=compileonly which supports the asterisk operator


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301959: Compile command in compiler.loopopts.TestRemoveEmptyCountedLoop does not work

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12575/head:pull/12575
$ git checkout pull/12575

Update a local copy of the PR:
$ git checkout pull/12575
$ git pull https://git.openjdk.org/jdk pull/12575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12575

View PR using the GUI difftool:
$ git pr show -t 12575

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12575.diff

@tobiasholenstein tobiasholenstein marked this pull request as ready for review February 15, 2023 16:08
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2023

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 15, 2023
@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 15, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2023

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.
Do we have a RFE to fix this inconsistency?

@openjdk
Copy link

openjdk bot commented Feb 15, 2023

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301959: Compile command in compiler.loopopts.TestRemoveEmptyCountedLoop does not work

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 195 new commits pushed to the master branch:

  • c29a136: 8291735: methods_do() always run at exit
  • 687a461: 8302464: Parallel: Remove unreachable code in callers of numa_has_static_binding
  • 84c058b: 8300549: JFileChooser Approve button tooltip is null in Aqua L&F in CUSTOM_DIALOG mode
  • e045af4: 8297031: IGV: Copy extracted nodes and layout for cloned graph
  • 53ae4c0: 8300645: Handle julong values in logging of GET_CONTAINER_INFO macros
  • c77f644: 8302625: Bad copyright line after JDK-8302385
  • 519229d: 8302385: Remove MetaspaceReclaimPolicy=none
  • 6e2d3c6: 8302455: VM.classloader_stats memory size values are wrong
  • 1480d41: 8208470: Type annotations on inner type that is an array component
  • 573c316: 8224980: FLAG_SET_ERGO silently ignores invalid values
  • ... and 185 more: https://git.openjdk.org/jdk/compare/59b7fb1a91c594f98f06b28cb95310a38565397d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 15, 2023
@tobiasholenstein
Copy link
Member Author

Good.
Do we have a RFE to fix this inconsistency?

I now filed one JDK-8302639

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@tobiasholenstein
Copy link
Member Author

Thanks @vnkozlov and @TobiHartmann !

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

Going to push as commit 9b911b4.
Since your change was applied there have been 195 commits pushed to the master branch:

  • c29a136: 8291735: methods_do() always run at exit
  • 687a461: 8302464: Parallel: Remove unreachable code in callers of numa_has_static_binding
  • 84c058b: 8300549: JFileChooser Approve button tooltip is null in Aqua L&F in CUSTOM_DIALOG mode
  • e045af4: 8297031: IGV: Copy extracted nodes and layout for cloned graph
  • 53ae4c0: 8300645: Handle julong values in logging of GET_CONTAINER_INFO macros
  • c77f644: 8302625: Bad copyright line after JDK-8302385
  • 519229d: 8302385: Remove MetaspaceReclaimPolicy=none
  • 6e2d3c6: 8302455: VM.classloader_stats memory size values are wrong
  • 1480d41: 8208470: Type annotations on inner type that is an array component
  • 573c316: 8224980: FLAG_SET_ERGO silently ignores invalid values
  • ... and 185 more: https://git.openjdk.org/jdk/compare/59b7fb1a91c594f98f06b28cb95310a38565397d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2023
@openjdk openjdk bot closed this Feb 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2023
@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@tobiasholenstein Pushed as commit 9b911b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants