8302667: Improve message format when failing to load symbols or libraries

[TheShermanTanker]

DLL_ERROR4 is a macro expanding to an error message when a failure to load a generic item (shared libraries or an exported symbol from said libraries for example) occurs. "Error: loading:" is not a very pretty message, so this small change results in "Error: Failed to load %s" instead, which looks better and also means the message makes more sense if we want to append a reason behind as well, such as "Error: Failed to load libjvm.so because xxx"

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302667: Improve message format when failing to load symbols or libraries

Reviewers

• Mandy Chung (@mlchung - Reviewer) ⚠️ Review applies to 6b54816a

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12596/head:pull/12596
$ git checkout pull/12596

Update a local copy of the PR:
$ git checkout pull/12596
$ git pull https://git.openjdk.org/jdk pull/12596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12596

View PR using the GUI difftool:
$ git pr show -t 12596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12596.diff

[bridgekeeper]

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheShermanTanker The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (d923ef45)
• 02: Full - Incremental (6b54816a)
• 01: Full - Incremental (5f4370f8)
• 00: Full (43afc03a)

[TheShermanTanker]

/label hotspot

[openjdk]

@TheShermanTanker
The hotspot label was successfully added.

[mlchung]

This change is fine.

expandArgFile reports DLL_ERROR4 when it fails to read @arg-file which is unrelated to shared libraries. Would you mind also adding ARG_ERROR18 to replace DLL_ERROR4?

[TheShermanTanker]

@mlchung No problem, what should I define ARG_ERROR18 as?

[TheShermanTanker]

@mlchung No problem, what should I define ARG_ERROR18 as?

@mlchung ?

[mlchung]

What about:

#define ARG_ERROR18      "Error: reading %s"

[TheShermanTanker]

Alright, will do, just gimme a moment...

[mlchung]

Thanks in making the change.

[openjdk]

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302667: Improve message format when failing to load symbols or libraries

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

• f893d23: 8303024: (fs) WindowsFileSystem.supportedFileAttributeViews can use Set.of
• d7ada66: 8303084: G1 Heap region liveness verification has inverted return value
• 5d7e7e2: 8302760: Improve liveness/remembered set verification for G1
• b0e0f37: 8303067: G1: Remove unimplemented G1FullGCScope::heap_transition
• 1a62a12: 8302880: Fix includes in g1ConcurrentMarkObjArrayProcessor files
• ee37af4: 8302975: Remove redundant mark verification during G1 Full GC
• 83bea26: 8300575: JVMTI support when using alternative virtual thread implementation
• 25bfed3: 8302979: (fs) Files usage of SUPPORTED_CHARSETS could be simplified
• 0d5f743: 8303054: Remove unused variables in GCTraceTimeLoggerImpl::log_end
• adc29c3: 8302878: Group cmdline heap size checking together
• ... and 83 more: https://git.openjdk.org/jdk/compare/b8c9d6cdf60ea5e680eb00d5c01a1c4d2ed04006...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheShermanTanker]

@mlchung Thanks for the review! :)

[TheShermanTanker]

/integrate

[openjdk]

Going to push as commit 8de841d.
Since your change was applied there have been 93 commits pushed to the master branch:

• f893d23: 8303024: (fs) WindowsFileSystem.supportedFileAttributeViews can use Set.of
• d7ada66: 8303084: G1 Heap region liveness verification has inverted return value
• 5d7e7e2: 8302760: Improve liveness/remembered set verification for G1
• b0e0f37: 8303067: G1: Remove unimplemented G1FullGCScope::heap_transition
• 1a62a12: 8302880: Fix includes in g1ConcurrentMarkObjArrayProcessor files
• ee37af4: 8302975: Remove redundant mark verification during G1 Full GC
• 83bea26: 8300575: JVMTI support when using alternative virtual thread implementation
• 25bfed3: 8302979: (fs) Files usage of SUPPORTED_CHARSETS could be simplified
• 0d5f743: 8303054: Remove unused variables in GCTraceTimeLoggerImpl::log_end
• adc29c3: 8302878: Group cmdline heap size checking together
• ... and 83 more: https://git.openjdk.org/jdk/compare/b8c9d6cdf60ea5e680eb00d5c01a1c4d2ed04006...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker Pushed as commit 8de841d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.