Skip to content

8302678: validate_source fails after JDK-8293313#12599

Closed
dcubed-ojdk wants to merge 1 commit intoopenjdk:masterfrom
dcubed-ojdk:JDK-8302678
Closed

8302678: validate_source fails after JDK-8293313#12599
dcubed-ojdk wants to merge 1 commit intoopenjdk:masterfrom
dcubed-ojdk:JDK-8302678

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 16, 2023

A trivial copyright header fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12599/head:pull/12599
$ git checkout pull/12599

Update a local copy of the PR:
$ git checkout pull/12599
$ git pull https://git.openjdk.org/jdk pull/12599/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12599

View PR using the GUI difftool:
$ git pr show -t 12599

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12599.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review February 16, 2023 17:07
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2023

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Feb 16, 2023
@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302678: validate_source fails after JDK-8293313

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2023
@dcubed-ojdk
Copy link
Member Author

@bplb - Thanks for the fast review!

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2023

Going to push as commit 574b48c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2023
@openjdk openjdk bot closed this Feb 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2023
@openjdk
Copy link

openjdk bot commented Feb 16, 2023

@dcubed-ojdk Pushed as commit 574b48c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Feb 16, 2023

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8302678 branch February 16, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants