New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8302615: make JVMTI thread cpu time functions optional for virtual threads #12604
Conversation
👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into |
I assume we'll rev the JVMTI version at some point in 21. The change looks fine. It might be that we'll need to add a new capacity or add a field to jvmtiTimerInfo to say whether the implementation supports CPU time for virtual threads, but what we have now is okay. |
Thank you for review, Alan. |
@sspitsyn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 71 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
I will integrate this as a trivial fix. |
/integrate |
Going to push as commit 6b082fb.
Your commit was automatically rebased without conflicts. |
I've just spotted that we missed some text: GetCurrentThreadCpuTime has "The current thread may not be a virtual thread". GetThreadCpuTime has "The thread may not be a virtual thread". The changes that have been integrated allow these functions to support CPU time measurement so I think we will need to adjust both of these sentences in a follow up issue. |
This is a minor JVM TI spec update for two timer functions
GetCurrentThreadCpuTime
andGetThreadCpuTime
to allow implementations to support virtual threads.The CSR is:
JDK-8302616: make JVMTI thread cpu time functions optional for virtual threads
No testing is needed.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12604/head:pull/12604
$ git checkout pull/12604
Update a local copy of the PR:
$ git checkout pull/12604
$ git pull https://git.openjdk.org/jdk pull/12604/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12604
View PR using the GUI difftool:
$ git pr show -t 12604
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12604.diff