8302150: Speed up compiler/codegen/Test7100757.java

[eme64]

This test took over 11 seconds. It had a very high iteration count of 5_000_000.

I lowered it to 50_000, it now takes about 0.7 seconds, so over 15x speedup.

I ensured that the same compilations still happen, with and without -Xbatch, this is the reason why I could not set it all the way down to 10_000 (the speedup at this point was hardly noticable anyway):

    554 1023       3       compiler.codegen.Test7100757::test (274 bytes)
    561 1028 %     4       compiler.codegen.Test7100757::test @ 14 (274 bytes)
    578 1033       4       compiler.codegen.Test7100757::test (274 bytes)
    593 1023       3       compiler.codegen.Test7100757::test (274 bytes)   made not entrant
    599 1034 %     3       compiler.codegen.Test7100757::main @ 32 (65 bytes)
    600 1035       3       compiler.codegen.Test7100757::main (65 bytes)
    615 1036 %     4       compiler.codegen.Test7100757::main @ 32 (65 bytes)
    635 1034 %     3       compiler.codegen.Test7100757::main @ 32 (65 bytes)   made not entrant
    676 1036 %     4       compiler.codegen.Test7100757::main @ 32 (65 bytes)   made not entrant

I am not sure if the test only reproduced intermittently, but if it did it would now probably reproduce with lower frequency, but hopefully still eventually (maybe 100x less less often). Or maybe the original author just did not notice that the iteration count was a bit excessive.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302150: Speed up compiler/codegen/Test7100757.java

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12618/head:pull/12618
$ git checkout pull/12618

Update a local copy of the PR:
$ git checkout pull/12618
$ git pull https://git.openjdk.org/jdk pull/12618/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12618

View PR using the GUI difftool:
$ git pr show -t 12618

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12618.diff

[bridgekeeper]

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eme64 The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5cb0f3b3)

[vnkozlov]

Good.

[openjdk]

@eme64 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302150: Speed up compiler/codegen/Test7100757.java

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 2009dc2: 8302462: [REDO] 8297487: G1 Remark: no need to keep alive oop constants of nmethods on stack
• 7abe269: 8302781: CDS archive heap not reproducible after JDK-8296344
• d6716d2: 8302315: Examine cost of clone of primitive arrays compared to arraycopy
• 53be5dc: 8302812: JDK-8302455 broke ClassLoaderStatsTest on 32-bit
• 78f71b4: 8301873: Avoid string decoding in ZipFile.Source.getEntryPos
• f82385e: 8302623: jarsigner - use BufferedOutputStream to improve performance while creating the signed jar
• 43cf8b3: 8302664: Fix several incorrect usages of Preconditions.checkFromIndexSize
• 6b082fb: 8302615: make JVMTI thread cpu time functions optional for virtual threads
• 7c60b9c: 8302358: Behavior of adler32 changes after JDK-8300208
• 86b9fce: 8301992: Embed SymbolTable CHT node
• ... and 3 more: https://git.openjdk.org/jdk/compare/6120319afdba98b5ff547b870a0260479e8b683c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good.

[eme64]

Thanks @TobiHartmann @vnkozlov for the reviews!
/integrate

[openjdk]

Going to push as commit 16a4f02.
Since your change was applied there have been 38 commits pushed to the master branch:

• 17274c7: 8302146: Move TestOverloadCompileQueues.java to tier3
• 29f392e: 8299522: Incorrect size of Approve button in custom JFileChooser
• 43c71dd: 8302453: RISC-V: Add support for small width vector operations
• 91a2b5e: 8302905: arm32 Raspberry Pi OS build broken by JDK-8301494
• bb3dfd6: 8302879: doc/building.md update link to jtreg builds
• 36a0822: 8302369: Reduce the stack size of the C1 compiler
• 0bf3a53: 8302599: Extend ASan support to Microsoft Visual C++
• c7517b3: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously
• 9a79722: 8299234: JMX Repository.query performance
• e47e9ec: 8300658: memory_and_swap_limit() reporting wrong values on systems with swapaccount=0
• ... and 28 more: https://git.openjdk.org/jdk/compare/6120319afdba98b5ff547b870a0260479e8b683c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@eme64 Pushed as commit 16a4f02.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.