Skip to content

8302144: Move ZeroTLABTest.java to tier3#12620

Closed
eme64 wants to merge 2 commits intoopenjdk:masterfrom
eme64:JDK-8302144
Closed

8302144: Move ZeroTLABTest.java to tier3#12620
eme64 wants to merge 2 commits intoopenjdk:masterfrom
eme64:JDK-8302144

Conversation

@eme64
Copy link
Contributor

@eme64 eme64 commented Feb 17, 2023

This is a "Hello World" test for the flags UseTLAB and ZeroTLAB, running with -Xcomp. It takes about 30seconds.
This test does not need to run on tier1. So I pushed it out to tier3.

Moved it to tier3, by adding it to hotspot_slow_compiler, which is excluded from tier1 and tier2.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12620/head:pull/12620
$ git checkout pull/12620

Update a local copy of the PR:
$ git checkout pull/12620
$ git pull https://git.openjdk.org/jdk pull/12620/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12620

View PR using the GUI difftool:
$ git pr show -t 12620

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12620.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2023

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@eme64 The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Feb 17, 2023
@eme64 eme64 marked this pull request as ready for review February 17, 2023 16:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 17, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2023

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 20, 2023

@eme64 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302144: Move ZeroTLABTest.java to tier3

Reviewed-by: thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 4c985e5: 8303183: Memory leak in Arguments::init_shared_archive_paths
  • 6af17c1: 8303362: Serial: Move CardTableRS to serial directory
  • c1e77e0: 8303252: G1: Return early from Full-GC if no regions are selected for compaction.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 20, 2023
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

@eme64
Copy link
Contributor Author

eme64 commented Mar 2, 2023

Thanks @TobiHartmann @vnkozlov for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

Going to push as commit 99f5687.
Since your change was applied there have been 9 commits pushed to the master branch:

  • dc08216: 8303186: Missing Classpath exception from Continuation.c
  • d10d40a: 8303077: JFR: Add example usage to jdk.jfr
  • 394eac8: 8295425: Match the default priv exp length between SunPKCS11 and other JDK providers
  • 6e19387: 8303070: Memory leak in DCmdArgument<char*>::parse_value
  • 9fc518f: 8303401: Add a Vector API equalsIgnoreCase micro benchmark
  • 05faa73: 8303232: java.util.Date.parse(String) and java.util.Date(String) don't declare thrown IllegalArgumentException
  • 4c985e5: 8303183: Memory leak in Arguments::init_shared_archive_paths
  • 6af17c1: 8303362: Serial: Move CardTableRS to serial directory
  • c1e77e0: 8303252: G1: Return early from Full-GC if no regions are selected for compaction.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 2, 2023
@openjdk openjdk bot closed this Mar 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@eme64 Pushed as commit 99f5687.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants