Skip to content

8302783: Improve CRC32C intrinsic with crypto pmull on AArch64 #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8302783: Improve CRC32C intrinsic with crypto pmull on AArch64 #12624

wants to merge 1 commit into from

Conversation

yftsai
Copy link
Contributor

@yftsai yftsai commented Feb 17, 2023 •
edited by openjdk bot
Loading

This change adds a pmull-based CRC32C intrinsic, and it is more performant than the existing crc32c-instruction-based intrinsic on Neoverse V1. The benchmark shows 10 - 99% improvement. The improvement comes from the execution throughput increase of pmull/pmull2 from 1 on Neoverse N1 to 4 on Neoverse V1 while the latency remains 2 while the throughput of CRC32C instructions did not changed.

The pmull-based CRC32C intrinsic is enabled by the existing option UseCryptoPmullForCRC32 which also enables the pmull-based CRC32 intrinsic. The option requires crc32c instructions, eor3 in SHA3, and 64-bit pmull/pmull2 in Cryptographic Extension.

With this change, there will be only two different CRC32C intrinsics, crc32c and pmull, while there are four CRC32 intrinsics.

The following test has passed.
test/hotspot/jtreg/compiler/intrinsics/zip/TestCRC32C.java

The throughput reported by the micro benchmark is measured on an EC2 c7g instance. The optimization shows 10 - 99% improvement when the input is at least 384 bytes.

input 64 128 256 384 511 512 1,024
improvement 1.60% 0.00% 0.00% 15.24% 10.76% 34.32% 72.39%
input 2,048 4,096 8,192 16,384 32,768 65,536
improvement 84.96% 92.59% 96.19% 98.02% 99.32% 98.36%

Baseline

Benchmark                    (count)   Mode  Cnt       Score      Error   Units
TestCRC32C.testCRC32CUpdate       64  thrpt   12  196575.739 ± 1824.113  ops/ms
TestCRC32C.testCRC32CUpdate      128  thrpt   12  123666.570 ±    2.730  ops/ms
TestCRC32C.testCRC32CUpdate      256  thrpt   12   70188.989 ±    2.002  ops/ms
TestCRC32C.testCRC32CUpdate      384  thrpt   12   49000.690 ±    1.421  ops/ms
TestCRC32C.testCRC32CUpdate      511  thrpt   12   34106.279 ±   25.390  ops/ms
TestCRC32C.testCRC32CUpdate      512  thrpt   12   37638.349 ±    1.039  ops/ms
TestCRC32C.testCRC32CUpdate     1024  thrpt   12   19526.513 ±    0.439  ops/ms
TestCRC32C.testCRC32CUpdate     2048  thrpt   12    9951.392 ±    4.803  ops/ms
TestCRC32C.testCRC32CUpdate     4096  thrpt   12    5023.268 ±    0.240  ops/ms
TestCRC32C.testCRC32CUpdate     8192  thrpt   12    2523.877 ±    0.062  ops/ms
TestCRC32C.testCRC32CUpdate    16384  thrpt   12    1265.011 ±    0.047  ops/ms
TestCRC32C.testCRC32CUpdate    32768  thrpt   12     632.291 ±    0.058  ops/ms
TestCRC32C.testCRC32CUpdate    65536  thrpt   12     315.396 ±    0.160  ops/ms

Crypto pmull

Benchmark                    (count)   Mode  Cnt       Score     Error   Units
TestCRC32C.testCRC32CUpdate       64  thrpt   12  199726.599 ± 166.477  ops/ms
TestCRC32C.testCRC32CUpdate      128  thrpt   12  123669.385 ±   1.821  ops/ms
TestCRC32C.testCRC32CUpdate      256  thrpt   12   70188.727 ±   1.313  ops/ms
TestCRC32C.testCRC32CUpdate      384  thrpt   12   56468.837 ±  76.524  ops/ms
TestCRC32C.testCRC32CUpdate      511  thrpt   12   37777.205 ± 406.431  ops/ms
TestCRC32C.testCRC32CUpdate      512  thrpt   12   50554.555 ±  17.169  ops/ms
TestCRC32C.testCRC32CUpdate     1024  thrpt   12   33661.006 ± 140.471  ops/ms
TestCRC32C.testCRC32CUpdate     2048  thrpt   12   18406.482 ± 205.952  ops/ms
TestCRC32C.testCRC32CUpdate     4096  thrpt   12    9674.159 ±  20.390  ops/ms
TestCRC32C.testCRC32CUpdate     8192  thrpt   12    4951.562 ±   6.566  ops/ms
TestCRC32C.testCRC32CUpdate    16384  thrpt   12    2504.970 ±   1.883  ops/ms
TestCRC32C.testCRC32CUpdate    32768  thrpt   12    1260.278 ±   0.484  ops/ms
TestCRC32C.testCRC32CUpdate    65536  thrpt   12     625.608 ±   0.300  ops/ms

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302783: Improve CRC32C intrinsic with crypto pmull on AArch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12624/head:pull/12624
$ git checkout pull/12624

Update a local copy of the PR:
$ git checkout pull/12624
$ git pull https://git.openjdk.org/jdk pull/12624/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12624

View PR using the GUI difftool:
$ git pr show -t 12624

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12624.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2023

👋 Welcome back yftsai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 17, 2023
@openjdk
Copy link

openjdk bot commented Feb 17, 2023

@yftsai The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Feb 17, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2023

Webrevs

simonis
simonis approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@simonis simonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

Thanks,
Volker

@openjdk
Copy link

openjdk bot commented Mar 1, 2023 •
edited
Loading

@yftsai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302783: Improve CRC32C intrinsic with crypto pmull on AArch64

Reviewed-by: simonis, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 181 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@simonis, @phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 1, 2023
@yftsai
Copy link
Contributor Author

yftsai commented Mar 1, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 1, 2023
@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@yftsai
Your change (at version f5de21a) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

The linux-x86 pre-submit test failure is caused by a test using -XX:+UseCompressedClassPointers, which is an invalid switch for 32-bit JVMs.

The linux-cross-compile pre-submit test failure is a compile-time failure in src/hotspot/cpu/arm/interpreterRT_arm.cpp, which latter is not touched by this patch.

phohensee
phohensee approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

Going to push as commit f3abc40.
Since your change was applied there have been 181 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 2, 2023
@openjdk openjdk bot closed this Mar 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@phohensee @yftsai Pushed as commit f3abc40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yftsai yftsai deleted the pmull_crc32c branch March 2, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonis simonis simonis approved these changes

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yftsai @phohensee @simonis