8290903: Enable function warning attribute for Clang build once Clang supports merging

[afshin-zafari]

The warning attribute is enabled..

Test

mach5 tier1-5.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8290903: Enable function warning attribute for Clang build once Clang supports merging

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12634/head:pull/12634
$ git checkout pull/12634

Update a local copy of the PR:
$ git checkout pull/12634
$ git pull https://git.openjdk.org/jdk.git pull/12634/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12634

View PR using the GUI difftool:
$ git pr show -t 12634

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12634.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back afshin-zafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3d3d7127)

[dholmes-ora]

I'm a bit confused about the status here. Looking at:

llvm/llvm-project#56519

the issue is still open, not fixed. And the issue is reported as existing in version 14 so the uncommented version check seems wrong anyway. ??

[afshin-zafari]

I'm a bit confused about the status here. Looking at:

llvm/llvm-project#56519

the issue is still open, not fixed. And the issue is reported as existing in version 14 so the uncommented version check seems wrong anyway. ??

The Fix Version of this issue is 21, so I mistakenly thought it is time for implementing the required changes.
I had to double check it first. Thanks for your time.

[bridgekeeper]

@afshin-zafari This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@afshin-zafari This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.