JDK-8302800: Augment NaN handling tests of FDLIBM methods

[jddarcy]

Augment NaN-handling tests to include exotic NaN bit patterns. Assuming this changeset goes back first, I'll update #12608 to follow the same convention afterward.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302800: Augment NaN handling tests of FDLIBM methods

Reviewers

• Brian Burkhalter (@bplb - Reviewer) ⚠️ Review applies to b4f2a1dd

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12644/head:pull/12644
$ git checkout pull/12644

Update a local copy of the PR:
$ git checkout pull/12644
$ git pull https://git.openjdk.org/jdk pull/12644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12644

View PR using the GUI difftool:
$ git pr show -t 12644

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12644.diff

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e2b8486d)
• 00: Full (b4f2a1dd)

[rgiulietti]

Not directly related to this PR and just out of curiosity: is there a reason for this to be volatile and non-final?

[jddarcy]

The comment on the PLATFORM_NAN field was mean to address that -- an attempt to make sure the expression to create the platform NaN gets evaluated at runtime rather than being constant-folded at compile time.

[rgiulietti]

Otherwise LGTM

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302800: Augment NaN handling tests of FDLIBM methods

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• 5489c82: 8302603: Use Set.of in java.nio.charset.Charset
• 10b4cc9: 8301627: System.exit and Runtime.exit debug logging
• db483a3: 8302320: AsyncGetCallTrace obtains too few frames in sanity test
• 02eb240: 8302846: IGV: Zoom stuck when zooming out on large graphs
• 92dfa11: 8302863: Speed up String::encodeASCII using countPositives
• 8b20aa9: 8302981: Fix a typo in the doc comment for java.lang.Record.equals
• 644fe0a: 8302837: Kernel32.cpp array memory release invokes undefined behaviour
• 60e6378: 8302977: ZGC: Doesn't support gc/TestVerifySubSet.java
• fef1910: 8299777: Test runtime/NMT/BaselineWithParameter.java timed out
• 622f560: 8302886: Parallel: Remove unimplemented methods in ParCompactionManager
• ... and 37 more: https://git.openjdk.org/jdk/compare/43cf8b3d8067bc7128c98f86d5f8b6fa8bbed80e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jddarcy]

/integrate

[openjdk]

Going to push as commit dfce4e1.
Since your change was applied there have been 47 commits pushed to the master branch:

• 5489c82: 8302603: Use Set.of in java.nio.charset.Charset
• 10b4cc9: 8301627: System.exit and Runtime.exit debug logging
• db483a3: 8302320: AsyncGetCallTrace obtains too few frames in sanity test
• 02eb240: 8302846: IGV: Zoom stuck when zooming out on large graphs
• 92dfa11: 8302863: Speed up String::encodeASCII using countPositives
• 8b20aa9: 8302981: Fix a typo in the doc comment for java.lang.Record.equals
• 644fe0a: 8302837: Kernel32.cpp array memory release invokes undefined behaviour
• 60e6378: 8302977: ZGC: Doesn't support gc/TestVerifySubSet.java
• fef1910: 8299777: Test runtime/NMT/BaselineWithParameter.java timed out
• 622f560: 8302886: Parallel: Remove unimplemented methods in ParCompactionManager
• ... and 37 more: https://git.openjdk.org/jdk/compare/43cf8b3d8067bc7128c98f86d5f8b6fa8bbed80e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy Pushed as commit dfce4e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.