8302837: Kernel32.cpp array memory release invokes undefined behaviour

[TheShermanTanker]

When several arrays are allocated with the new operator in Kernel32, they use the wrong set of delete operators when freeing the allocated memory. In C++ this is undefined behaviour and they should be converted to use the correct operators

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302837: Kernel32.cpp array memory release invokes undefined behaviour

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12649/head:pull/12649
$ git checkout pull/12649

Update a local copy of the PR:
$ git checkout pull/12649
$ git pull https://git.openjdk.org/jdk pull/12649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12649

View PR using the GUI difftool:
$ git pr show -t 12649

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12649.diff

[bridgekeeper]

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheShermanTanker The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (25a5487b)

[lahodaj]

Looks sensible to me. Thanks!

[openjdk]

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302837: Kernel32.cpp array memory release invokes undefined behaviour

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 60e6378: 8302977: ZGC: Doesn't support gc/TestVerifySubSet.java
• fef1910: 8299777: Test runtime/NMT/BaselineWithParameter.java timed out
• 622f560: 8302886: Parallel: Remove unimplemented methods in ParCompactionManager
• 9fd77c7: 8302868: Serial: Remove CardTableRS::initialize
• f35cf79: 8302867: G1: Removing unused variable in G1CardTable::initialize
• 63a3501: 8302741: ZGC: Remove Universe::verify calls
• 9145670: 8301661: Enhance os::pd_print_cpu_info on macOS and Windows
• aa10f0d: 8302151: BMPImageReader throws an exception reading BMP images
• 16a4f02: 8302150: Speed up compiler/codegen/Test7100757.java
• 17274c7: 8302146: Move TestOverloadCompileQueues.java to tier3
• ... and 24 more: https://git.openjdk.org/jdk/compare/2009dc2b737b3468ba6c78d4bf2f5a0bba20ec43...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheShermanTanker]

Thanks for the review! :D

[TheShermanTanker]

/integrate

[openjdk]

Going to push as commit 644fe0a.
Since your change was applied there have been 34 commits pushed to the master branch:

• 60e6378: 8302977: ZGC: Doesn't support gc/TestVerifySubSet.java
• fef1910: 8299777: Test runtime/NMT/BaselineWithParameter.java timed out
• 622f560: 8302886: Parallel: Remove unimplemented methods in ParCompactionManager
• 9fd77c7: 8302868: Serial: Remove CardTableRS::initialize
• f35cf79: 8302867: G1: Removing unused variable in G1CardTable::initialize
• 63a3501: 8302741: ZGC: Remove Universe::verify calls
• 9145670: 8301661: Enhance os::pd_print_cpu_info on macOS and Windows
• aa10f0d: 8302151: BMPImageReader throws an exception reading BMP images
• 16a4f02: 8302150: Speed up compiler/codegen/Test7100757.java
• 17274c7: 8302146: Move TestOverloadCompileQueues.java to tier3
• ... and 24 more: https://git.openjdk.org/jdk/compare/2009dc2b737b3468ba6c78d4bf2f5a0bba20ec43...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker Pushed as commit 644fe0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.