8302838: jabswitch main() should avoid calling exit explicitly

[TheShermanTanker]

In jabswitch, main is defined as void main(), which requires an explicit exit call whenever an error occurs, and extra error checking code on our part. Visual C++ will automatically convert all instances of void main() to return 0 in all cases anyway, and there isn't anything gained from using this custom signature when the same can be achieved by simply returning the error value normally, so I propose we simply change it to the regular int main signature

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302838: jabswitch main() should avoid calling exit explicitly

Reviewers

• @SWinxy (no known openjdk.org user name / role) ⚠️ Review applies to c5783d47
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12650/head:pull/12650
$ git checkout pull/12650

Update a local copy of the PR:
$ git checkout pull/12650
$ git pull https://git.openjdk.org/jdk pull/12650/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12650

View PR using the GUI difftool:
$ git pr show -t 12650

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12650.diff

[bridgekeeper]

👋 Welcome back jwaters! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheShermanTanker The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a04b8f51)
• 00: Full (c5783d47)

[openjdk]

@TheShermanTanker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302838: jabswitch main() should avoid calling exit explicitly

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• f319c92: 8303016: Invalid escapes in grep patterns
• e950b95: 8303033: Build failure with the micro bench mark
• dcd773a: 8302864: Parallel: Remove PSVirtualSpace::pointer_delta
• 46f2525: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint
• ce6de37: 8303010: Add /DEBUG to LDFLAGS for MSVC with ASan
• 729c26f: 8303020: Remove carriage return in pandoc version string
• ef1f7bd: 8302877: Speed up latin1 case conversions
• 1ea5f9f: 8302789: (fs) Files.copy should include unsupported copy option in exception message
• dfce4e1: 8302800: Augment NaN handling tests of FDLIBM methods
• 5489c82: 8302603: Use Set.of in java.nio.charset.Charset

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheShermanTanker]

/integrate

[openjdk]

Going to push as commit cba817a.
Since your change was applied there have been 12 commits pushed to the master branch:

• 2c52cf0: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
• 180b94c: 8302907: [PPC64] Use more constexpr in class Register
• f319c92: 8303016: Invalid escapes in grep patterns
• e950b95: 8303033: Build failure with the micro bench mark
• dcd773a: 8302864: Parallel: Remove PSVirtualSpace::pointer_delta
• 46f2525: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint
• ce6de37: 8303010: Add /DEBUG to LDFLAGS for MSVC with ASan
• 729c26f: 8303020: Remove carriage return in pandoc version string
• ef1f7bd: 8302877: Speed up latin1 case conversions
• 1ea5f9f: 8302789: (fs) Files.copy should include unsupported copy option in exception message
• ... and 2 more: https://git.openjdk.org/jdk/compare/10b4cc9eb49c14a6be03b3f53e97037529169ed1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker Pushed as commit cba817a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.