Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Feb 20, 2023

Simple removing redundant code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302864: Parallel: Remove PSVirtualSpace::pointer_delta

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12657/head:pull/12657
$ git checkout pull/12657

Update a local copy of the PR:
$ git checkout pull/12657
$ git pull https://git.openjdk.org/jdk pull/12657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12657

View PR using the GUI difftool:
$ git pr show -t 12657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12657.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8302864 8302864: Parallel: Remove PSVirtualSpace::pointer_delta Feb 20, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2023
@openjdk
Copy link

openjdk bot commented Feb 20, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 20, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@openjdk
Copy link

openjdk bot commented Feb 20, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302864: Parallel: Remove PSVirtualSpace::pointer_delta

Reviewed-by: tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • 1ea5f9f: 8302789: (fs) Files.copy should include unsupported copy option in exception message
  • dfce4e1: 8302800: Augment NaN handling tests of FDLIBM methods
  • 5489c82: 8302603: Use Set.of in java.nio.charset.Charset
  • 10b4cc9: 8301627: System.exit and Runtime.exit debug logging
  • db483a3: 8302320: AsyncGetCallTrace obtains too few frames in sanity test
  • 02eb240: 8302846: IGV: Zoom stuck when zooming out on large graphs
  • 92dfa11: 8302863: Speed up String::encodeASCII using countPositives
  • 8b20aa9: 8302981: Fix a typo in the doc comment for java.lang.Record.equals
  • 644fe0a: 8302837: Kernel32.cpp array memory release invokes undefined behaviour
  • 60e6378: 8302977: ZGC: Doesn't support gc/TestVerifySubSet.java
  • ... and 47 more: https://git.openjdk.org/jdk/compare/fef3eab9bd2d61cc25752fe11a65bdc3010beae3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 20, 2023
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 21, 2023

Going to push as commit dcd773a.
Since your change was applied there have been 61 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2023
@openjdk openjdk bot closed this Feb 21, 2023
@albertnetymk albertnetymk deleted the pgc-pointer-delta branch February 21, 2023 21:24
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 21, 2023
@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@albertnetymk Pushed as commit dcd773a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants