8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState

[kevinjwalls]

Test update to make failures such as JDK-8076494 more informative.

Waiting for a thread to change state: give more time (to distinguish a real deadlock from some other delay), and log the thread stackframes when the expected state change is not observed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12661/head:pull/12661
$ git checkout pull/12661

Update a local copy of the PR:
$ git checkout pull/12661
$ git pull https://git.openjdk.org/jdk pull/12661/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12661

View PR using the GUI difftool:
$ git pr show -t 12661

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12661.diff

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7e45ff0e)
• 00: Full (6e930abf)

[dholmes-ora]

Approach is fine in principle but a few minor nits.

Thanks.

[kevinjwalls]

OK thanks David, nits taken care of I think. (I'm not falling for the trap of changing all the indenting so nobody can see from the diff what I'm changing here, so I suppressed my instincts and used 8 spaces.)

[dholmes-ora]

Update looks good - thanks.

I have no issue if you change the file indents after the PR is approved and then integrate - as it is only whitespace change. :)

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState

Reviewed-by: dholmes, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

• f54e108: 8302831: PPC: compiler/codecache/TestStressCodeBuffers.java fails after JDK-8301819
• cba817a: 8302838: jabswitch main() should avoid calling exit explicitly
• 2c52cf0: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
• 180b94c: 8302907: [PPC64] Use more constexpr in class Register
• f319c92: 8303016: Invalid escapes in grep patterns
• e950b95: 8303033: Build failure with the micro bench mark
• dcd773a: 8302864: Parallel: Remove PSVirtualSpace::pointer_delta
• 46f2525: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint
• ce6de37: 8303010: Add /DEBUG to LDFLAGS for MSVC with ASan
• 729c26f: 8303020: Remove carriage return in pandoc version string
• ... and 70 more: https://git.openjdk.org/jdk/compare/49eb68ba958794fe547cccd00725192cc7063043...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Looks good.
Thanks,
Serguei

[kevinjwalls]

Thanks David and Serguei!
(leaving whitespace unification alone for now... 8-) )

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 5e1d1b7.
Since your change was applied there have been 82 commits pushed to the master branch:

• 7f35389: 8302888: containers/docker/TestJcmd.java fails when run as root under podman
• b6ecca1: 8280113: (dc) DatagramSocket.receive does not always throw when the channel is closed
• f54e108: 8302831: PPC: compiler/codecache/TestStressCodeBuffers.java fails after JDK-8301819
• cba817a: 8302838: jabswitch main() should avoid calling exit explicitly
• 2c52cf0: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
• 180b94c: 8302907: [PPC64] Use more constexpr in class Register
• f319c92: 8303016: Invalid escapes in grep patterns
• e950b95: 8303033: Build failure with the micro bench mark
• dcd773a: 8302864: Parallel: Remove PSVirtualSpace::pointer_delta
• 46f2525: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint
• ... and 72 more: https://git.openjdk.org/jdk/compare/49eb68ba958794fe547cccd00725192cc7063043...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 5e1d1b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.