Skip to content

8302880: Fix includes in g1ConcurrentMarkObjArrayProcessor files #12671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Feb 20, 2023

Hi all,

please review this change that fixes includes in g1ConcurrentMarkObjArrayProcessor*.

Testing: local compilation

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302880: Fix includes in g1ConcurrentMarkObjArrayProcessor files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12671/head:pull/12671
$ git checkout pull/12671

Update a local copy of the PR:
$ git checkout pull/12671
$ git pull https://git.openjdk.org/jdk pull/12671/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12671

View PR using the GUI difftool:
$ git pr show -t 12671

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12671.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2023

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8302867 8302867: G1: Removing unused variable in G1CardTable::initialize Feb 20, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 20, 2023
@openjdk
Copy link

openjdk bot commented Feb 20, 2023

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Feb 20, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2023

Webrevs

@tschatzl tschatzl changed the title 8302867: G1: Removing unused variable in G1CardTable::initialize 8302880 Feb 20, 2023
@openjdk openjdk bot changed the title 8302880 8302880: Fix includes in g1ConcurrentMarkObjArrayProcessor files Feb 20, 2023
@openjdk
Copy link

openjdk bot commented Feb 20, 2023

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302880: Fix includes in g1ConcurrentMarkObjArrayProcessor files

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • f54e108: 8302831: PPC: compiler/codecache/TestStressCodeBuffers.java fails after JDK-8301819
  • cba817a: 8302838: jabswitch main() should avoid calling exit explicitly
  • 2c52cf0: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
  • 180b94c: 8302907: [PPC64] Use more constexpr in class Register
  • f319c92: 8303016: Invalid escapes in grep patterns
  • e950b95: 8303033: Build failure with the micro bench mark
  • dcd773a: 8302864: Parallel: Remove PSVirtualSpace::pointer_delta
  • 46f2525: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint
  • ce6de37: 8303010: Add /DEBUG to LDFLAGS for MSVC with ASan
  • 729c26f: 8303020: Remove carriage return in pandoc version string
  • ... and 34 more: https://git.openjdk.org/jdk/compare/98716e2b251c5e86e840116d0c70e2bb07993a10...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 20, 2023
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tschatzl
Copy link
Contributor Author

Thanks @albertnetymk @kimbarret for your reviews
/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2023

Going to push as commit 1a62a12.
Since your change was applied there have been 58 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2023
@openjdk openjdk bot closed this Feb 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2023
@openjdk
Copy link

openjdk bot commented Feb 22, 2023

@tschatzl Pushed as commit 1a62a12.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8302880-includes-inobjarrayprocessor branch February 22, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants