8302907: [PPC64] Use more constexpr in class Register

[TheRealMDoerr]

We should use constexpr more often in order to make it better usable. (I got compile errors when trying to use the encoding() in another constexpr.)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302907: [PPC64] Use more constexpr in class Register

Reviewers

• Richard Reingruber (@reinrich - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12681/head:pull/12681
$ git checkout pull/12681

Update a local copy of the PR:
$ git checkout pull/12681
$ git pull https://git.openjdk.org/jdk pull/12681/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12681

View PR using the GUI difftool:
$ git pr show -t 12681

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12681.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d160d711)

[reinrich]

Looks good.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302907: [PPC64] Use more constexpr in class Register

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 622f560: 8302886: Parallel: Remove unimplemented methods in ParCompactionManager
• 9fd77c7: 8302868: Serial: Remove CardTableRS::initialize
• f35cf79: 8302867: G1: Removing unused variable in G1CardTable::initialize
• 63a3501: 8302741: ZGC: Remove Universe::verify calls
• 9145670: 8301661: Enhance os::pd_print_cpu_info on macOS and Windows
• aa10f0d: 8302151: BMPImageReader throws an exception reading BMP images
• 16a4f02: 8302150: Speed up compiler/codegen/Test7100757.java
• 17274c7: 8302146: Move TestOverloadCompileQueues.java to tier3
• 29f392e: 8299522: Incorrect size of Approve button in custom JFileChooser

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

Thanks for the review! Pre-submit tests failure is unrelated (x86, but this PR only touches PPC64).

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit 180b94c.
Since your change was applied there have been 27 commits pushed to the master branch:

• f319c92: 8303016: Invalid escapes in grep patterns
• e950b95: 8303033: Build failure with the micro bench mark
• dcd773a: 8302864: Parallel: Remove PSVirtualSpace::pointer_delta
• 46f2525: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint
• ce6de37: 8303010: Add /DEBUG to LDFLAGS for MSVC with ASan
• 729c26f: 8303020: Remove carriage return in pandoc version string
• ef1f7bd: 8302877: Speed up latin1 case conversions
• 1ea5f9f: 8302789: (fs) Files.copy should include unsupported copy option in exception message
• dfce4e1: 8302800: Augment NaN handling tests of FDLIBM methods
• 5489c82: 8302603: Use Set.of in java.nio.charset.Charset
• ... and 17 more: https://git.openjdk.org/jdk/compare/43c71ddf923d442499449948f4bf8a7c79249af0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 180b94c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.