JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

[jcking]

Add /DEBUG to LDFLAGS for MSVC with ASan. Without it MSVC produces lots of warnings.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12693/head:pull/12693
$ git checkout pull/12693

Update a local copy of the PR:
$ git checkout pull/12693
$ git pull https://git.openjdk.org/jdk pull/12693/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12693

View PR using the GUI difftool:
$ git pr show -t 12693

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12693.diff

[bridgekeeper]

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jcking The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[jcking]

@magicus Trivial change for ASan under MSVC. Was giving it a run through tier1 today and noticed MSVC complaining heavily in build logs about -DEBUG not being passed. Adding it to LDFLAGS to shut it up, confirmed its quiet now.

[mlbridge]

Webrevs

• 00: Full (6a84a384)

[openjdk]

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303010: Add /DEBUG to LDFLAGS for MSVC with ASan

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 1ea5f9f: 8302789: (fs) Files.copy should include unsupported copy option in exception message
• dfce4e1: 8302800: Augment NaN handling tests of FDLIBM methods
• 5489c82: 8302603: Use Set.of in java.nio.charset.Charset

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jcking]

Linux GHA tests look unrelated. This is MSVC-only change.

[jcking]

/integrate

[openjdk]

Going to push as commit ce6de37.
Since your change was applied there have been 5 commits pushed to the master branch:

• 729c26f: 8303020: Remove carriage return in pandoc version string
• ef1f7bd: 8302877: Speed up latin1 case conversions
• 1ea5f9f: 8302789: (fs) Files.copy should include unsupported copy option in exception message
• dfce4e1: 8302800: Augment NaN handling tests of FDLIBM methods
• 5489c82: 8302603: Use Set.of in java.nio.charset.Charset

Your commit was automatically rebased without conflicts.

[openjdk]

@jcking Pushed as commit ce6de37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

If ASAN support needs -debug wouldn't it make sense to restrict its use to debug builds?

[jcking]

If ASAN support needs -debug wouldn't it make sense to restrict its use to debug builds?

MSVC named it poorly, IMO. It just means generate PDB basically.

It doesn't need it, just complains that stack traces are better with it.