8303024: (fs) WindowsFileSystem.supportedFileAttributeViews can use Set.of

[Glavo]

Simply clean up. I need someone to help me open an issue on JBS, thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303024: (fs) WindowsFileSystem.supportedFileAttributeViews can use Set.of

Reviewers

• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12697/head:pull/12697
$ git checkout pull/12697

Update a local copy of the PR:
$ git checkout pull/12697
$ git pull https://git.openjdk.org/jdk pull/12697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12697

View PR using the GUI difftool:
$ git pr show -t 12697

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12697.diff

[bridgekeeper]

👋 Welcome back Glavo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Glavo The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[stsypanov]

Hi @Glavo, to track this you can use this one https://bugs.openjdk.org/browse/JDK-8303024

[Glavo]

Hi @Glavo, to track this you can use this one https://bugs.openjdk.org/browse/JDK-8303024

Thanks.

[mlbridge]

Webrevs

• 00: Full (a4938b8c)

[bplb]

Looks okay.

[bplb]

In order to match the JBS issue, the title of this PR should be changed to:

"8303024: (fs) WindowsFileSystem.supportedFileAttributeViews can use Set.of"

[openjdk]

@Glavo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303024: (fs) WindowsFileSystem.supportedFileAttributeViews can use Set.of

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• dcd773a: 8302864: Parallel: Remove PSVirtualSpace::pointer_delta
• 46f2525: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint
• ce6de37: 8303010: Add /DEBUG to LDFLAGS for MSVC with ASan
• 729c26f: 8303020: Remove carriage return in pandoc version string
• ef1f7bd: 8302877: Speed up latin1 case conversions
• 1ea5f9f: 8302789: (fs) Files.copy should include unsupported copy option in exception message
• dfce4e1: 8302800: Augment NaN handling tests of FDLIBM methods

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[Glavo]

/integrate

[openjdk]

@Glavo
Your change (at version a4938b8) is now ready to be sponsored by a Committer.

[bplb]

/sponsor

[openjdk]

Going to push as commit f893d23.
Since your change was applied there have been 31 commits pushed to the master branch:

• d7ada66: 8303084: G1 Heap region liveness verification has inverted return value
• 5d7e7e2: 8302760: Improve liveness/remembered set verification for G1
• b0e0f37: 8303067: G1: Remove unimplemented G1FullGCScope::heap_transition
• 1a62a12: 8302880: Fix includes in g1ConcurrentMarkObjArrayProcessor files
• ee37af4: 8302975: Remove redundant mark verification during G1 Full GC
• 83bea26: 8300575: JVMTI support when using alternative virtual thread implementation
• 25bfed3: 8302979: (fs) Files usage of SUPPORTED_CHARSETS could be simplified
• 0d5f743: 8303054: Remove unused variables in GCTraceTimeLoggerImpl::log_end
• adc29c3: 8302878: Group cmdline heap size checking together
• 5754848: 8299338: AssertionError in ResponseSubscribers$HttpResponseInputStream::onSubscribe
• ... and 21 more: https://git.openjdk.org/jdk/compare/5489c821dc2e0c3cfa207dc96d9183d165640368...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb @Glavo Pushed as commit f893d23.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.