Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302512: Update IANA Language Subtag Registry to Version 2023-02-14 #12699

Closed

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Feb 21, 2023

Incorporate the latest IANA language subtag registry definition (2023-02-14).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302512: Update IANA Language Subtag Registry to Version 2023-02-14

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12699/head:pull/12699
$ git checkout pull/12699

Update a local copy of the PR:
$ git checkout pull/12699
$ git pull https://git.openjdk.org/jdk pull/12699/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12699

View PR using the GUI difftool:
$ git pr show -t 12699

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12699.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2023
@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Feb 21, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2023

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the copyright year for the test changes.

* @summary Checks the IANA language subtag registry data update
* (LSR Revision: 2022-08-08) with Locale and Locale.LanguageRange
* (LSR Revision: 2023-2-14) with Locale and Locale.LanguageRange
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add prepending 0 to the month to keep the YYYY-MM-DD format.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching, fixed

@openjdk
Copy link

openjdk bot commented Feb 21, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302512: Update IANA Language Subtag Registry to Version 2023-02-14

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 143 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 21, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 23, 2023
@openjdk
Copy link

openjdk bot commented Feb 23, 2023

@justin-curtis-lu
Your change (at version b502f52) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Feb 23, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 23, 2023

Going to push as commit f612dcf.
Since your change was applied there have been 151 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 23, 2023
@openjdk openjdk bot closed this Feb 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 23, 2023
@openjdk
Copy link

openjdk bot commented Feb 23, 2023

@naotoj @justin-curtis-lu Pushed as commit f612dcf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants