Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253029: [PPC64] Remove obsolete Power6 code #127

Closed
wants to merge 1 commit into from

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 11, 2020

New pull request:
Using a branch, updated Copyright, removed some more unused code.

[Previous text]
The recent PPC64 platform files still contain code which is part of a Power6 optimization called Power6Scheduler. However, this functionality was never completely contributed so it was never usable in the OpenJDK.
We should remove it since we're no longer optimizing for Power6.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/127/head:pull/127
$ git checkout pull/127

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 11, 2020

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2020

@TheRealMDoerr The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

Loading

@openjdk openjdk bot added the hotspot label Sep 11, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 11, 2020

Webrevs

Loading

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Sep 14, 2020

/csr needed

Loading

@openjdk openjdk bot added the csr label Sep 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@dholmes-ora this pull request will not be integrated until the CSR request JDK-8253046 for issue JDK-8253029 has been approved.

Loading

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Code changes seem fine.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@TheRealMDoerr This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253029: [PPC64] Remove obsolete Power6 code

Reviewed-by: dholmes, lucy
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 23 commits pushed to the master branch:

  • e6a493a: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler
  • 68da63d: 8240658: Code completion not working for lambdas in method invocations that require type inference
  • b05290a: 8252898: remove bulk registration of JFR CompilerPhaseType names
  • 779d2c3: 8253084: Zero VM is broken after JDK-8252689
  • 07da3a1: 8253030: ZGC: Change ZMarkCompleteTimeout unit to microseconds
  • f978f6f: 8252689: Classes are loaded from jrt:/java.base even when CDS is used
  • c5e63b6: 8248186: Move CDS C++ vtable code to cppVtables.cpp
  • 03a4df0: 8244778: Archive full module graph in CDS
  • 998ce78: 8252543: [JVMCI] Libgraal can deadlock in blocking compilation mode
  • b1b0f0b: 8253066: typo in Stream.mapMulti
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/ff21696bc00d447bda61df826f1ff2d2ab2cf969...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e6a493ab8820e38493308342621c3c7993b06ccb.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 14, 2020
@RealLucy
Copy link
Contributor

@RealLucy RealLucy commented Sep 14, 2020

Hi Martin,
your changes look good to me.
Thanks for the tedious comments removal! Not a task you been for.
Best,
Lutz

Loading

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Sep 14, 2020

Thanks for the reviews.

Loading

@TheRealMDoerr TheRealMDoerr changed the title 8253029: Remove obsolete Power6 code 8253029: [PPC64] Remove obsolete Power6 code Sep 14, 2020
@openjdk openjdk bot removed the csr label Sep 14, 2020
@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Sep 14, 2020

/integrate

Loading

@openjdk openjdk bot closed this Sep 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2020

@TheRealMDoerr Since your change was applied there have been 23 commits pushed to the master branch:

  • e6a493a: 8252882: Clean up jdk.javadoc and the related parts of jdk.compiler
  • 68da63d: 8240658: Code completion not working for lambdas in method invocations that require type inference
  • b05290a: 8252898: remove bulk registration of JFR CompilerPhaseType names
  • 779d2c3: 8253084: Zero VM is broken after JDK-8252689
  • 07da3a1: 8253030: ZGC: Change ZMarkCompleteTimeout unit to microseconds
  • f978f6f: 8252689: Classes are loaded from jrt:/java.base even when CDS is used
  • c5e63b6: 8248186: Move CDS C++ vtable code to cppVtables.cpp
  • 03a4df0: 8244778: Archive full module graph in CDS
  • 998ce78: 8252543: [JVMCI] Libgraal can deadlock in blocking compilation mode
  • b1b0f0b: 8253066: typo in Stream.mapMulti
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/ff21696bc00d447bda61df826f1ff2d2ab2cf969...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9c24a56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@TheRealMDoerr TheRealMDoerr deleted the Power6Cleanup branch Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants