-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8253029: [PPC64] Remove obsolete Power6 code #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
@TheRealMDoerr The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
/csr needed |
@dholmes-ora this pull request will not be integrated until the CSR request JDK-8253046 for issue JDK-8253029 has been approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes seem fine.
@TheRealMDoerr This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 23 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
Hi Martin, |
Thanks for the reviews. |
/integrate |
@TheRealMDoerr Since your change was applied there have been 23 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9c24a56. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
New pull request:
Using a branch, updated Copyright, removed some more unused code.
[Previous text]
The recent PPC64 platform files still contain code which is part of a Power6 optimization called Power6Scheduler. However, this functionality was never completely contributed so it was never usable in the OpenJDK.
We should remove it since we're no longer optimizing for Power6.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/127/head:pull/127
$ git checkout pull/127