Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8297605 DelayQueue javadoc is confusing #12727

Closed
wants to merge 1 commit into from

Conversation

viktorklang-ora
Copy link
Contributor

@viktorklang-ora viktorklang-ora commented Feb 23, 2023

Clarifies the distinction between expiration of the head of DelayQueue and how it relates to poll, take, and peek. See discussion on https://bugs.openjdk.org/browse/JDK-8297605

@DougLea If possible, please weigh in on whether this is in line with your thoughts on the matter.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12727/head:pull/12727
$ git checkout pull/12727

Update a local copy of the PR:
$ git checkout pull/12727
$ git pull https://git.openjdk.org/jdk pull/12727/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12727

View PR using the GUI difftool:
$ git pr show -t 12727

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12727.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2023

👋 Welcome back viktorklang-ora! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 23, 2023
@openjdk
Copy link

openjdk bot commented Feb 23, 2023

@viktorklang-ora The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 23, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2023

Webrevs

@viktorklang-ora
Copy link
Contributor Author

Reopening this as a new PR due to a weird validation error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
1 participant