8303082 : [AIX] Missing C++ name demangling with XLClang++ #12742

deepa181 · 2023-02-24T15:16:08Z

It was failing as It was using the C++ demangling interface (Demangle) of the old demangler (that is, the C++ API as opposed to the C one). It is not supported by xlclang++ on AIX.
To demangle names generated by xlclang++ , use cxxabi.h __cxa_demangle interface ( see cxxabi.h).

This Solution applies to the following test

SecondaryErrorTest.java`
TestSigInfoInHsErrFile.java

Reported Issue : JDK - 8303082

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8303082: [AIX] Missing C++ name demangling with XLClang++

Reviewers

Tyler Steele (@backwaterred - Committer) ⚠️ Review applies to 49f0267e
Martin Doerr (@TheRealMDoerr - Reviewer)
Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12742/head:pull/12742
$ git checkout pull/12742

Update a local copy of the PR:
$ git checkout pull/12742
$ git pull https://git.openjdk.org/jdk.git pull/12742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12742

View PR using the GUI difftool:
$ git pr show -t 12742

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12742.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-02-24T15:17:36Z

👋 Welcome back deepa181! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-02-24T15:19:48Z

@deepa181 The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

src/hotspot/os/aix/porting_aix.cpp

backwaterred · 2023-02-24T16:37:26Z

Thanks for looking at this Deepa! This fixes an issue that I had always noticed, but never got around to digging in to :-)

deepa181 · 2023-02-24T20:57:24Z

Thanks for looking at this Deepa! This fixes an issue that I had always noticed, but never got around to digging in to :-)

Thank you @backwaterred .

TheShermanTanker · 2023-02-26T06:40:12Z

@deepa181 You have to fix whitespace errors before the integration system will allow this to be reviewed. Any tabs are not allowed, only spaces

openjdk · 2023-02-27T06:36:14Z

@deepa181 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

deepa181 · 2023-02-27T06:40:18Z

@deepa181 You have to fix whitespace errors before the integration system will allow this to be reviewed. Any tabs are not allowed, only spaces

Thanks for review @TheShermanTanker . I removed extra whitespaces.

mlbridge · 2023-02-27T06:40:50Z

Webrevs

openjdk · 2023-02-27T10:14:13Z

@deepa181 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

backwaterred

LGTM

deepa181 · 2023-03-23T05:30:18Z

LGTM

Thanks @backwaterred .

deepa181 · 2023-03-30T06:28:15Z

Hi @TheRealMDoerr ,

Could you please review this PR?

Thanks.

TheRealMDoerr

Thanks for implementing it! Looks basically good to me. Please consider my suggestions.

src/hotspot/os/aix/porting_aix.cpp

openjdk · 2023-03-31T08:52:56Z

@deepa181 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

This reverts commit bd602ab.

openjdk · 2023-04-04T10:22:42Z

@deepa181 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

TheRealMDoerr

LGTM.

openjdk · 2023-04-04T12:36:16Z

@deepa181 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303082: [AIX] Missing C++ name demangling with XLClang++

Reviewed-by: tsteele, mdoerr, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 478 new commits pushed to the master branch:

7b92210: 8305525: Problemlist runtime/ErrorHandling/TestDwarf on x86
5881b09: 8305500: SystemDictionary::find_placeholder/find_class declared but not used
7ca2aec: 8304033: JFR: Missing thread
ac01e24: 8305242: Remove non-invariant assert(EventThreadDump::is_enabled())
a663d5d: 8305520: ToggleNotifyJvmtiTest.java fails with release VMs
24c6af0: 8173709: Fix VerifyLoopOptimizations - step 1 - minimal infrastructure
a7546b3: 8304996: Add missing HandleMarks
ac898e9: 8303278: Imprecise bottom type of ExtractB/UB
a1a9ec6: 8297286: runtime/vthread tests crashing after JDK-8296324
c6bd489: 8305206: Add @SPEC tags in java.base/java.* (part 1)
... and 468 more: https://git.openjdk.org/jdk/compare/fbc036e7454720b589d99a8cae30369a10471528...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@backwaterred, @TheRealMDoerr, @tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

tstuefe

Looks good!

deepa181 · 2023-04-04T13:48:22Z

LGTM.

Thanks @TheRealMDoerr .

deepa181 · 2023-04-04T13:49:08Z

Looks good!

Thanks @tstuefe for Suggesting and helping.

deepa181 · 2023-04-04T13:49:50Z

/integrate

openjdk · 2023-04-04T13:50:55Z

@deepa181
Your change (at version 597515c) is now ready to be sponsored by a Committer.

TheRealMDoerr · 2023-04-04T14:24:18Z

/sponsor

openjdk · 2023-04-04T14:26:33Z

Going to push as commit f9ed825.
Since your change was applied there have been 479 commits pushed to the master branch:

73a084c: 8305504: stutter typo in java.compiler files
7b92210: 8305525: Problemlist runtime/ErrorHandling/TestDwarf on x86
5881b09: 8305500: SystemDictionary::find_placeholder/find_class declared but not used
7ca2aec: 8304033: JFR: Missing thread
ac01e24: 8305242: Remove non-invariant assert(EventThreadDump::is_enabled())
a663d5d: 8305520: ToggleNotifyJvmtiTest.java fails with release VMs
24c6af0: 8173709: Fix VerifyLoopOptimizations - step 1 - minimal infrastructure
a7546b3: 8304996: Add missing HandleMarks
ac898e9: 8303278: Imprecise bottom type of ExtractB/UB
a1a9ec6: 8297286: runtime/vthread tests crashing after JDK-8296324
... and 469 more: https://git.openjdk.org/jdk/compare/fbc036e7454720b589d99a8cae30369a10471528...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-04-04T14:26:54Z

@TheRealMDoerr @deepa181 Pushed as commit f9ed825.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 24, 2023

jcking reviewed Feb 24, 2023

View reviewed changes

src/hotspot/os/aix/porting_aix.cpp Outdated Show resolved Hide resolved

backwaterred suggested changes Feb 24, 2023

View reviewed changes

src/hotspot/os/aix/porting_aix.cpp Outdated Show resolved Hide resolved

src/hotspot/os/aix/porting_aix.cpp Outdated Show resolved Hide resolved

deepa181 closed this Feb 24, 2023

deepa181 reopened this Feb 24, 2023

deepa181 force-pushed the secondaryErr branch 2 times, most recently from 43eae94 to 4c65dda Compare February 24, 2023 20:37

deepa181 marked this pull request as ready for review February 24, 2023 20:52

deepa181 force-pushed the secondaryErr branch from 4c65dda to a81a688 Compare February 27, 2023 06:35

openjdk bot added the rfr Pull request is ready for review label Feb 27, 2023

deepa181 force-pushed the secondaryErr branch from 4ed1f9d to 49f0267 Compare February 27, 2023 10:13

backwaterred approved these changes Feb 27, 2023

View reviewed changes

deepa181 requested review from jcking and backwaterred and removed request for jcking and backwaterred March 21, 2023 10:29

backwaterred approved these changes Mar 22, 2023

View reviewed changes

deepa181 requested a review from jcking March 23, 2023 05:31

TheRealMDoerr reviewed Mar 30, 2023

View reviewed changes

src/hotspot/os/aix/porting_aix.cpp Show resolved Hide resolved

src/hotspot/os/aix/porting_aix.cpp Outdated Show resolved Hide resolved

8303082 : [AIX] Missing C++ name demangling with XLClang++

1b05a7d

deepa181 force-pushed the secondaryErr branch from 49f0267 to 1b05a7d Compare March 31, 2023 08:51

deepa181 added 2 commits April 4, 2023 15:48

8303082 : [AIX] Missing C++ name demangling with XLClang++

24f789d

Revert "8303082 : [AIX] Missing C++ name demangling with XLClang++"

8a46c6e

This reverts commit bd602ab.

deepa181 force-pushed the secondaryErr branch from 71107a5 to 8a46c6e Compare April 4, 2023 10:21

Remove free scope

597515c

TheRealMDoerr approved these changes Apr 4, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2023

tstuefe approved these changes Apr 4, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 4, 2023

openjdk bot added the integrated Pull request has been integrated label Apr 4, 2023

openjdk bot closed this Apr 4, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 4, 2023

8303082 : [AIX] Missing C++ name demangling with XLClang++ #12742

8303082 : [AIX] Missing C++ name demangling with XLClang++ #12742

Uh oh!

Conversation

deepa181 commented Feb 24, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Feb 24, 2023

Uh oh!

openjdk bot commented Feb 24, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

backwaterred commented Feb 24, 2023

Uh oh!

deepa181 commented Feb 24, 2023

Uh oh!

TheShermanTanker commented Feb 26, 2023

Uh oh!

openjdk bot commented Feb 27, 2023

Uh oh!

deepa181 commented Feb 27, 2023

Uh oh!

mlbridge bot commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk bot commented Feb 27, 2023

Uh oh!

backwaterred left a comment

Choose a reason for hiding this comment

Uh oh!

deepa181 commented Mar 23, 2023

Uh oh!

deepa181 commented Mar 30, 2023

Uh oh!

TheRealMDoerr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

openjdk bot commented Mar 31, 2023

Uh oh!

openjdk bot commented Apr 4, 2023

Uh oh!

TheRealMDoerr left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tstuefe left a comment

Choose a reason for hiding this comment

Uh oh!

deepa181 commented Apr 4, 2023

Uh oh!

deepa181 commented Apr 4, 2023

Uh oh!

deepa181 commented Apr 4, 2023

Uh oh!

openjdk bot commented Apr 4, 2023

Uh oh!

TheRealMDoerr commented Apr 4, 2023

Uh oh!

openjdk bot commented Apr 4, 2023

Uh oh!

openjdk bot commented Apr 4, 2023

Uh oh!

Uh oh!

deepa181 commented Feb 24, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 27, 2023 •

edited

Loading

openjdk bot commented Apr 4, 2023 •

edited

Loading