Skip to content

8303083: (bf) Remove private DirectByteBuffer(long, int) constructor before JDK 21 GA #12745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Feb 24, 2023

Remove the DirectByteBuffer constructor what was originally removed by #11873 and subsequently reinstated #12717.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303083: (bf) Remove private DirectByteBuffer(long, int) constructor before JDK 21 GA

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12745/head:pull/12745
$ git checkout pull/12745

Update a local copy of the PR:
$ git checkout pull/12745
$ git pull https://git.openjdk.org/jdk pull/12745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12745

View PR using the GUI difftool:
$ git pr show -t 12745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12745.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 24, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 24, 2023
@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Feb 24, 2023
@mlbridge
Copy link

mlbridge bot commented Feb 24, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303083: (bf) Remove private DirectByteBuffer(long, int) constructor before JDK 21 GA

Reviewed-by: alanb, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 83d77b1: 8303072: Memory leak in exeNullCallerTest.cpp
  • 7d8b8ba: 8303131: pandoc.exe mangles all processed html files
  • 8f7c496: 8302810: NMT gtests don't correctly check for marked ranges
  • 1a07871: 8302173: Button border overlaps with button icon on macOS system LaF
  • 796cdd5: 8302677: JFR: Cache label and contentType in EventType and ValueDescriptor
  • 6b24b4a: 8302821: JFR: Periodic task thread spins after recording has stopped
  • 4d33fbd: 8303089: [jittester] Add time limit to IRTree generation
  • f612dcf: 8302512: Update IANA Language Subtag Registry to Version 2023-02-14
  • 6397cb6: 8301200: Don't scale timeout stress with timeout factor
  • 71dd7ea: 8303085: Runtime problem list cleanup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 24, 2023
@bplb
Copy link
Member Author

bplb commented Feb 24, 2023

Top three test tiers pass on all platforms.

@bplb
Copy link
Member Author

bplb commented Feb 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Feb 24, 2023

Going to push as commit ccf3340.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 83d77b1: 8303072: Memory leak in exeNullCallerTest.cpp
  • 7d8b8ba: 8303131: pandoc.exe mangles all processed html files
  • 8f7c496: 8302810: NMT gtests don't correctly check for marked ranges
  • 1a07871: 8302173: Button border overlaps with button icon on macOS system LaF
  • 796cdd5: 8302677: JFR: Cache label and contentType in EventType and ValueDescriptor
  • 6b24b4a: 8302821: JFR: Periodic task thread spins after recording has stopped
  • 4d33fbd: 8303089: [jittester] Add time limit to IRTree generation
  • f612dcf: 8302512: Update IANA Language Subtag Registry to Version 2023-02-14
  • 6397cb6: 8301200: Don't scale timeout stress with timeout factor
  • 71dd7ea: 8303085: Runtime problem list cleanup

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 24, 2023
@openjdk openjdk bot closed this Feb 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 24, 2023
@openjdk
Copy link

openjdk bot commented Feb 24, 2023

@bplb Pushed as commit ccf3340.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the DirectByteBuffer-8303083 branch February 27, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants