8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal

[bplb]

Deprecate SensitivityWatchEventModifier for now instead of directly removing it as proposed in #12626.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8303188 to be approved

Issues

• JDK-8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal
• JDK-8303188: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal (CSR)

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer) ⚠️ Review applies to b3ea4f71
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12746/head:pull/12746
$ git checkout pull/12746

Update a local copy of the PR:
$ git checkout pull/12746
$ git pull https://git.openjdk.org/jdk pull/12746/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12746

View PR using the GUI difftool:
$ git pr show -t 12746

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12746.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (ca92fdba)
• 03: Full - Incremental (45d63422)
• 02: Full - Incremental (f00174e5)
• 01: Full - Incremental (b3ea4f71)
• 00: Full (694ecfeb)

[LanceAndersen]

Hi Brian,

I believe we need a CSR for this

[bplb]

I believe we need a CSR for this

@LanceAndersen I concur.

[bplb]

/csr

[openjdk]

@bplb has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-8303175 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303175: (fs) Deprecate com.sun.nio.file.SensitivityWatchEventModifier for removal

Reviewed-by: lancea, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

• 45d8a17: 8303405: fix @returnss typo in ReflectionFactory
• e7113dc: 8302495: update for deprecated sprintf for java.desktop
• 843d632: 8303442: Clean up w2k_lsa_auth linker parameters
• d4dcba0: 8303267: Prefer ArrayList to LinkedList in ConcurrentLocksPrinter
• 2c7d2c0: 8303411: JFR problem list entry for JDK-8247776 should be removed
• 0b63557: 8303039: Utilize coverageLevels.txt
• 32247c3: 8303476: Add the runtime version in the release file of a JDK image
• 0926d0c: 8302516: Do some cleanup of nsk/share/jdi/EventHandler.java
• b51ea42: 8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
• fb13063: 8303409: Add Windows AArch64 ABI support to the Foreign Function & Memory API
• ... and 74 more: https://git.openjdk.org/jdk/compare/4b6acad0bd7729c39e807cd35c40b0fe4a14783c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit ae29054.
Since your change was applied there have been 106 commits pushed to the master branch:

• a04b104: 8303413: (fs) Ignore polling interval sensitivity modifiers in PollingWatchService
• 9944314: 8303587: Remove VMOutOfMemoryError001 test from the problem list after 8303198
• a50dc67: 8303527: update for deprecated sprintf for jdk.hotspot.agent
• 40c5edf: 8303181: Memory leak in ClassLoaderExt::setup_app_search_path
• 29ee7c3: 8303523: Cleanup problem listing of nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java
• e3016c1: 8303472: Display name for region TR
• ae797c6: 8301117: Remove old_size param from ResizeableResourceHashtable::resize()
• 5085bd5: 8297936: Use reachabilityFence to manage liveness in ClassUnload tests
• 379f206: 8303198: System and Runtime.exit() resilience to logging errors
• 80739e1: 8279619: [JVMCI] improve EncodedSpeculationReason
• ... and 96 more: https://git.openjdk.org/jdk/compare/4b6acad0bd7729c39e807cd35c40b0fe4a14783c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit ae29054.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.