8302795: Shared archive failed on old version class with jsr bytecode

[calvinccheung]

Please review this simple fix for avoid writing in to CDS archive during runtime while loading a shared old class (major_version < 50) with methods containg the jsr byte code.
Otherwise, JVM crashes with the following message in the hs err log:
Error accessing class data sharing archive. Mapped file inaccessible during execution, possible disk/network problem.

Passed tiers 1 - 4 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8302795: Shared archive failed on old version class with jsr bytecode

Reviewers

• Yumin Qi (@yminqi - Reviewer)
• Matias Saavedra Silva (@matias9927 - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12752/head:pull/12752
$ git checkout pull/12752

Update a local copy of the PR:
$ git checkout pull/12752
$ git pull https://git.openjdk.org/jdk pull/12752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12752

View PR using the GUI difftool:
$ git pr show -t 12752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12752.diff

[calvinccheung]

/label add hotspot-runtime

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (ecea6558)
• 00: Full (6a8b5251)

[dholmes-ora]

Sorry I'm having a little trouble following the problem and solution here. The problem IIUC:

• If we load a class with JSR bytecodes then we have to rewrite those to avoid the use of JSR.
• If we dumped such a class into the shared archive it is in the RO part of the archive.
• If we attempt to rewrite a class in the RO section then we crash.

The solution would seem to be a choice of:
a) don't rewrite the class; or
b) don't archive it

The solution presented here seems to be (a) but I thought we had to rewrite classes with JSR bytecodes ???

[calvinccheung]

The solution would seem to be a choice of: a) don't rewrite the class; or b) don't archive it

The solution presented here seems to be (a) but I thought we had to rewrite classes with JSR bytecodes ???

Option b is harder to do because we currently cannot link old classes during dump time. So we can't simply do the following check to see is a jsr bytecode is present during dump time.
m->has_jsrs()

In order to do the above check during dump time, for an "old" class, we'll need to check all the methods and for each method check all the byte codes and see if a jsr bytecode is present.

I'll try to implement the above.

[calvinccheung]

I have pushed a commit. The fix is make the _methods array writable during dump time for "old" classes with the jsr byte code.
Ran tiers 1 - 3 testing successfully.

[dholmes-ora]

I'm not familiar enough with CDS to review this in detail sorry. The approach sounds reasonable.

Thanks

[yminqi]

LGTM. We know after 49.0 (java 5), jsr will not be generated, so this should not be a problem for dynamic dumping too.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302795: Shared archive failed on old version class with jsr bytecode

Reviewed-by: minqi, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 254 new commits pushed to the master branch:

• c466cdf: 8299546: C2: MulLNode::mul_ring() wrongly returns bottom type due to casting errors with large numbers
• 55aa122: 8304059: Use InstanceKlass in dependencies
• ec1eb00: 8303415: Add VM_Version::is_intrinsic_supported(id)
• 31680b2: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options
• 0cc0f06: 8304015: G1: Metaspace-induced GCs should not trigger maximal compaction
• 43eca1d: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests
• b6d70f2: 8303973: Library detection in runtime/ErrorHandling/TestDwarf.java fails on ppc64le RHEL8.5 for libpthread-2.28.so
• 2bb990e: 8301244: Tidy up compiler specific warnings files
• c073ef2: 8303482: Update LCMS to 2.15
• 49181b8: 8303955: RISC-V: Factor out the tmp parameter from copy_memory and copy_memory_v
• ... and 244 more: https://git.openjdk.org/jdk/compare/07e976ac26fe3ff6a94713013114dc38c95950b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

This makes sense, rewriting the method should rewrite the JSR bytecodes and any matching RET bytecodes. LGTM!

[calvinccheung]

Thanks @yminqi and @matias9927 for the review.

/integrate

[openjdk]

Going to push as commit 830fd41.
Since your change was applied there have been 259 commits pushed to the master branch:

• 4e631fa: 8298966: Deprecate JMX Subject Delegation and the method JMXConnector.getMBeanServerConnection(Subject) for removal.
• 10f1674: 8303809: Dispose context in SPNEGO NegotiatorImpl
• 9f9ab02: 8303895: Simplify and clean up LinkFactory code
• a00f5d2: 8303861: Error handling step timeouts should never be blocked by OnError and others
• da044dd: 8300939: sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to network errors
• c466cdf: 8299546: C2: MulLNode::mul_ring() wrongly returns bottom type due to casting errors with large numbers
• 55aa122: 8304059: Use InstanceKlass in dependencies
• ec1eb00: 8303415: Add VM_Version::is_intrinsic_supported(id)
• 31680b2: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options
• 0cc0f06: 8304015: G1: Metaspace-induced GCs should not trigger maximal compaction
• ... and 249 more: https://git.openjdk.org/jdk/compare/07e976ac26fe3ff6a94713013114dc38c95950b8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 830fd41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.