8303216: Prefer ArrayList to LinkedList in sun.net.httpserver.ServerImpl

[turbanoff]

LinkedList is used in a few places in ServerImpl.
There is only add/iterator/clear/size calls on this lists. No removes from the head or something like this. ArrayList should be preferred as more efficient and widely used (more chances for JIT) collection.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303216: Prefer ArrayList to LinkedList in sun.net.httpserver.ServerImpl

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Vyom Tewari (@vyommani - Committer)
• Sergey Tsypanov (@stsypanov - Author)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12756/head:pull/12756
$ git checkout pull/12756

Update a local copy of the PR:
$ git checkout pull/12756
$ git pull https://git.openjdk.org/jdk pull/12756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12756

View PR using the GUI difftool:
$ git pr show -t 12756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12756.diff

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3e59fa09)

[jaikiran]

Looks fine to me.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303216: Prefer ArrayList to LinkedList in sun.net.httpserver.ServerImpl

Reviewed-by: jpai, vtewari, stsypanov, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

• 30302d1: 8303250: Call ct_max_alignment_constraint using the base class
• e144783: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls
• 5feb13b: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened
• 1e3c9fd: 8026369: javac potentially ambiguous overload warning needs an improved scheme
• 14a014d: 8302124: HotSpot Style Guide should permit noreturn attribute
• bca60f4: 8303249: JFR: Incorrect description of dumponexit
• f7f1036: 8303068: Memory leak in DwarfFile::LineNumberProgram::run_line_number_program
• 784f7b1: 8293667: Align jlink's --compress option with jmod's --compress option
• 54603aa: 8303208: JFR: 'jfr print' displays incorrect timestamps
• 4c169d2: 8303253: Remove unnecessary calls to super() in java.time value based classes
• ... and 16 more: https://git.openjdk.org/jdk/compare/2fb1e3b7e72cf7836a9ffd9c6a5b09a6eef3c01b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vyommani]

Looks OK to me.

[turbanoff]

/integrate

[openjdk]

Going to push as commit 8815175.
Since your change was applied there have been 32 commits pushed to the master branch:

• a10d5ac: 8303130: Document required Accessibility permissions on macOS
• 50dc041: 8303227: JniObjWithEnv should be NullablePointer compliant
• 61e8867: 8302040: Port fdlibm sqrt to Java
• 6423065: 8303261: JFR: jdk/jfr/api/consumer/streaming/TestJVMCrash.java doesn't retry
• dc5ea6a: 8303350: Fix mistyped {@code}
• 4a415ad: 8303351: [IR Framework] Add missing cpu feature avx512bw after JDK-8302681
• 30302d1: 8303250: Call ct_max_alignment_constraint using the base class
• e144783: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls
• 5feb13b: 8301701: java/net/DatagramSocket/DatagramSocketMulticasting.java should be hardened
• 1e3c9fd: 8026369: javac potentially ambiguous overload warning needs an improved scheme
• ... and 22 more: https://git.openjdk.org/jdk/compare/2fb1e3b7e72cf7836a9ffd9c6a5b09a6eef3c01b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit 8815175.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.