Skip to content

8303421: [BACKOUT] 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.#12799

Closed
lmesnik wants to merge 1 commit intoopenjdk:masterfrom
lmesnik:8303421
Closed

8303421: [BACKOUT] 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.#12799
lmesnik wants to merge 1 commit intoopenjdk:masterfrom
lmesnik:8303421

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Mar 1, 2023

The backout for 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303421: [BACKOUT] 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12799/head:pull/12799
$ git checkout pull/12799

Update a local copy of the PR:
$ git checkout pull/12799
$ git pull https://git.openjdk.org/jdk pull/12799/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12799

View PR using the GUI difftool:
$ git pr show -t 12799

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12799.diff

…y if process exit before linePredicate is printed.

This reverts commit 1fdaf25.
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8303421: [BACKOUT] 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed. 8303421: [BACKOUT] 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed. Mar 1, 2023
@lmesnik
Copy link
Member Author

lmesnik commented Mar 1, 2023

/cc hotspot-runtime

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Mar 1, 2023
@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@lmesnik
The hotspot-runtime label was successfully added.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backout appears okay.

Thanks.

@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303421: [BACKOUT] 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 1, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2023

Webrevs

@lmesnik
Copy link
Member Author

lmesnik commented Mar 1, 2023

/inetgrate

@lmesnik
Copy link
Member Author

lmesnik commented Mar 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@lmesnik Unknown command inetgrate - for a list of valid commands use /help.

@openjdk
Copy link

openjdk bot commented Mar 1, 2023

Going to push as commit 3aeefbf.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2023
@openjdk openjdk bot closed this Mar 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 1, 2023
@openjdk
Copy link

openjdk bot commented Mar 1, 2023

@lmesnik Pushed as commit 3aeefbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lmesnik lmesnik deleted the 8303421 branch June 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants