8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient

[jaikiran]

Can I please get a review for this test-only change which addresses https://bugs.openjdk.org/browse/JDK-8303457?

Tests that reside in test/jdk/java/net/httpclient/ create and use test servers for executing various HttpClient tests against those test servers. As noted in the JBS issue, the code in most of these tests is repeated for the test server creation. All these tests use the test library at test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/.

The changes in this PR include a set of new APIs in test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java to help reduce the boilerplate. The rest of the changes across the existing tests is to use these new APIs. No functional changes to the tests has been done.

Locally the tests in test/jdk/java/net/httpclient/ continue to pass with these changes. tier testing is in progress to verify no unforeseen regressions are introduced.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12808/head:pull/12808
$ git checkout pull/12808

Update a local copy of the PR:
$ git checkout pull/12808
$ git pull https://git.openjdk.org/jdk pull/12808/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12808

View PR using the GUI difftool:
$ git pr show -t 12808

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12808.diff

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b4756039)

[dfuch]

Thanks Jaikiran, that looks very good. Approving on the condition that all modified tests still pass.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303457: Introduce convenience test library APIs for creating test servers for tests in test/jdk/java/net/httpclient

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 4c985e5: 8303183: Memory leak in Arguments::init_shared_archive_paths
• 6af17c1: 8303362: Serial: Move CardTableRS to serial directory

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Thank you Daniel. tier tests completed successfully. Plus, I ran java/net/httpclient tests with a repeat count of 50 and those too completed successfully. I'll integrate this shortly.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 72de24e.
Since your change was applied there have been 12 commits pushed to the master branch:

• 3091744: 8303418: Improve parameter and variable names in BitMap
• dbb562d: 8303355: The Depend plugin does fully recompile when primitive type changes
• 4619e8b: 8297587: Upgrade JLine to 3.22.0
• 99f5687: 8302144: Move ZeroTLABTest.java to tier3
• dc08216: 8303186: Missing Classpath exception from Continuation.c
• d10d40a: 8303077: JFR: Add example usage to jdk.jfr
• 394eac8: 8295425: Match the default priv exp length between SunPKCS11 and other JDK providers
• 6e19387: 8303070: Memory leak in DCmdArgument<char*>::parse_value
• 9fc518f: 8303401: Add a Vector API equalsIgnoreCase micro benchmark
• 05faa73: 8303232: java.util.Date.parse(String) and java.util.Date(String) don't declare thrown IllegalArgumentException
• ... and 2 more: https://git.openjdk.org/jdk/compare/c1e77e05647ca93bb4f39a320a5c7a632e283410...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 72de24e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.