8303486: [REDO] Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

[lmesnik]

It is the 2nd attempt to fix
JDK-8303133 Update ProcessTools.startProcess(...) to exit early if the process exit before linePredicate is printed.

The first fix failed because it runs
Utils.waitForCondition(BooleanSupplier condition, long timeout, long sleepTime) { ..}
with 0 as no timeout and not -1 as required.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303486: [REDO] Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12815/head:pull/12815
$ git checkout pull/12815

Update a local copy of the PR:
$ git checkout pull/12815
$ git pull https://git.openjdk.org/jdk pull/12815/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12815

View PR using the GUI difftool:
$ git pr show -t 12815

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12815.diff

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1be2041a)

[dholmes-ora]

Looks good.

Thanks

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303486: [REDO] Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• dc08216: 8303186: Missing Classpath exception from Continuation.c
• d10d40a: 8303077: JFR: Add example usage to jdk.jfr
• 394eac8: 8295425: Match the default priv exp length between SunPKCS11 and other JDK providers
• 6e19387: 8303070: Memory leak in DCmdArgument<char*>::parse_value
• 9fc518f: 8303401: Add a Vector API equalsIgnoreCase micro benchmark
• 05faa73: 8303232: java.util.Date.parse(String) and java.util.Date(String) don't declare thrown IllegalArgumentException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lmesnik]

/integrate

[openjdk]

Going to push as commit ae8730f.
Since your change was applied there have been 63 commits pushed to the master branch:

• 5977f26: 8303604: Passing by-value structs whose size is not power of 2 doesn't work on all platforms (mainline)
• dccfe8a: 8303582: Reduce duplication in jdk/java/foreign tests
• 8e20145: 8300654: Remove JVMFlag::flag_error_str as it is unused
• bdffe46: 8301222: Generalize check_release_entry in OopStorage
• ec4e8aa: 8303244: G1: call CardTable::clear_MemRegion directly
• 5753ab5: 8297454: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to show opaque button"
• fa1cebe: 8303266: Prefer ArrayList to LinkedList in JImageTask
• 5f153e0: 8302780: Add support for vectorized arraycopy GC barriers
• d00a767: 8295737: macOS: Print content cut off when width > height with portrait orientation
• 15c76e4: 8301254: UNIX sun/font coding does not detect SuSE in openSUSE Leap distribution
• ... and 53 more: https://git.openjdk.org/jdk/compare/4c985e527a4a03d5a78d85a145aa41c1843a3e22...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit ae8730f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.